gcsim icon indicating copy to clipboard operation
gcsim copied to clipboard

Substat Optimizer - No debug version

Open IvanHdzF opened this issue 2 years ago • 4 comments

From my understanding there's currently no way of disabling the debug log run when calling the sim, this makes run times take longer; originally this isn't a big issue per se when simulating normally, but it could take a bigger impact on the subs stat optimizer.

IvanHdzF avatar May 18 '22 00:05 IvanHdzF

@srliao I'm more interested in which aspects of this sim could be disabled during a substat optimization run. In theory I think we could turn off some of the logging operations, though this may impractical/impossible.

Turning off the debug log run is along that same vein, but small potatoes in the grand scheme of things.

jordanlovato avatar May 18 '22 02:05 jordanlovato

~~Note to self, I'm like 65% sure that we can queue up all of our sim runners as goroutines and distribute substats after all goroutines have returned. I don't think there's any reason to wait on each run of the sim. I think currently the substat optimizer is psudeo-synchronous processing 10-20 runs of gcsim.~~

Better to increase worker count on sim runs

jordanlovato avatar May 18 '22 04:05 jordanlovato

Next idea, can we do small sim_iter runs during optimization passes to guide the larger sim_iter runs? For example if we have 4 relevant subs, run each at 10 iters, build a gradient and discard anything significantly discrepent, then do another round of 350 passes on all remaining subs. If all but 1 sub were discarded, automatically allocate it and move onto the next char?

jordanlovato avatar May 19 '22 03:05 jordanlovato

Staeld — Today at 9:06 PM If I understood correctly, Raiden has a special case because she scales with ER, right? Shouldn't Mona also be considered or her ER scaling is not big enough to be a problem?

What about ESF, does it make sense to bias in favor of ER with ESF?

jordanlovato avatar May 19 '22 04:05 jordanlovato

no longer relevant

srliao avatar Mar 06 '24 17:03 srliao