gcsim icon indicating copy to clipboard operation
gcsim copied to clipboard

Substat Optimizer - Std Dev Optimization

Open jordanlovato opened this issue 2 years ago • 3 comments

Per convo in https://github.com/genshinsim/gcsim/pull/483

Currently we build substat gradients based on avg damage, then we interpret avg dmg gradients as our only consideration for whether any particular optimization action is "better"/"worse".

https://github.com/genshinsim/gcsim/blob/main/internal/substatoptimizer/substatoptimizer.go#L383-L393

Part of that consideration for "better"/"worse" ought to factor stdDev gradients as well. We should bias in favor of increasing damage, but I also think that we ought to consider decreasing stdDev as "better" and increasing stdDev as "worse". Both factors do not necessarily need to contribute to the determination of which substat to pick equally, but if that's easier to begin with, I think it's okay.

jordanlovato avatar May 12 '22 19:05 jordanlovato

@Charlie-Zheng did #1890 fix this?

k0l11 avatar Jan 12 '24 21:01 k0l11

Currently stddev isn't directly referenced as a target to reduce, which can result in some sims with high avg but also high stddev.

I will continue working on improvements and this will be one of the things I consider adding

Charlie-Zheng avatar Jan 12 '24 22:01 Charlie-Zheng

Ok, will leave open then.

k0l11 avatar Jan 12 '24 22:01 k0l11