Comprehensive Frame Update

[Tsym-or-Tysm]

Introduction

Purpose of this ticket is to keep track the recount of all characters in accordance with gcsim's frame framework, which differs slightly from existing count in that we require recovery frame and cancellable frame for all possible combination of actions.

We're looking for help from everyone with both recording and frame counting. If you are able to contribute please leave a comment below. Looking for help both in terms of just providing raw footage as well as performing the count. It'd help us greatly if you can provide help with either or (or both should you desire).

Recording requirement

• Record at consistent 60fps 720p minimum
• For each character, record all possible combinations of various ability, including but not limited to
  • string of normal attacks i.e. N1 -> N5 -> N1 (usually done by button mashing)
  • cancelling of each normal attack with charge attack i.e. N1 -> CA, N2 -> CA, etc...
  • cancelling of skill with every other possible action i.e. NA, CA, skill, burst, dash, jump swap
  • cancelling of burst with every other possible action i.e. NA, CA, skill, burst, dash, jump swap
  • cancelling of CA with every other possible action i.e. NA, CA, skill, burst, dash, jump swap
  • any other combinations for character with special abilities i.e. skill hold, etc...
• We'll need 3 trials of every combination to help average out any recording error
• All footage should be done vs empty air (not hitting trees) as sim is using no hitlag frames
• Footage should start clearly from standing/rest position and end at standing/rest position to avoid cutting off any part of the animation
• Footage should not be obstructed in anyways by trees, rocks, enemies, etc...

Frame count requirements

NX/CA hitmark / NX/CA hitmark when infused:
start frame: start of the animation of NX
end frame: hitmark registered on target = 2 frames after the frame where the yellow mark first appears 

E hitmark / Q hitmark / D hitmark (only if special dash):
start frame: first frame the buttons bottom right grey out
end frame: frame the element gets applied (Pyro/Hydro/Electro/Dendro?/Cryo) / the first frame the Swirl (Anemo) or Crystallize (Geo) text appears

NX -> NY:
start frame: start of the animation of NX
end frame: start of the animation of NY

NX -> CA:
start frame: start of the animation of NX
end frame: first frame the buttons bottom right grey out

CA/E/Q -> E/Q / D -> E/Q (only if special dash):
start frame: first frame the buttons bottom right grey out
end frame: first frame the buttons bottom right grey out for the next action

CA/E/Q -> N1/D/J / D -> N1/D (only if special dash):
start frame: first frame the buttons bottom right grey out
end frame: start of the animation of N1/D/J

CA/E/Q -> Swap  / D -> Swap (only if special dash):
start frame: first frame the buttons bottom right grey out
end frame: first frame the team names aren't grey'd out anymore

frames = end frame - start frame

Recount Status

character	link to sheet	videos	issue/pr	status
albedo	sheet	video	#671
aloy	sheet	video	#672
amber	sheet	video	#673
ayaka	sheet	video	#425
ayato	sheet	video	#458
barbara	sheet	video	#676
beidou	sheet	video	#527
bennett	sheet	video	#502
chongyun	sheet	video	#674
diluc	sheet	video	#510
diona	sheet	video	#675
eula	sheet	video	#477
fischl	sheet	video	#503
ganyu	sheet	video	#448
gorou	sheet	video	#677
heizou	sheet	video	#640
hutao	sheet	video	#665
itto	sheet	video	#661
jean	sheet	video	#460
kaeya	sheet	video	#678
kazuha	sheet	video	d10b8e0
keqing	sheet	video	#504
klee	sheet	video	#666
kokomi	sheet	video	#528
kuki	sheet	video	#679
lisa	sheet	video	#552
mona	sheet	video	#698
ningguang	sheet	video	#687
noelle	sheet	video	#447
qiqi	sheet	video	#680
raiden	sheet	video	#478
razor	sheet	video	#688
rosaria	sheet	video	#482
sara	sheet	video	#690
sayu	sheet	video	#704
shenhe	sheet	video	#689
sucrose	sheet	video	#463
tartaglia	sheet	video	#667
thoma	sheet	video	#684
traveleranemo			#734
travelerelectro			#734
travelergeo			#734
venti	sheet	video	#449
xiangling	sheet	video	#524
xiao	sheet	video	#511
xingqiu	sheet	video	#444
xinyan	sheet	video	#691
yaemiko	sheet	video	#692
yanfei	sheet	video	#693
yelan	sheet	video	srliao/gcsim#5
yoimiya	sheet	video	#529
yunjin	sheet	video	#695
zhongli	sheet	video	#508

Original issue:

This issue was hijacked to track the rework. Original comment from Tsym as follows:

This is a global issue to track frame data issues/fixes. After some investigation, the primary set of issues relate to how KQM frames are measured:

• For NA/CA frames, KQM frames are usually until hitmark (or from hitmark to hitmark). Currently, the frames that we have loaded are therefore usually ok until the last NA/CA in the sequence, when there will be no ending animation. However practically this is not a significant concern because most NA/CA chains in the game are cancelled in some way (mostly through dashes or jumps).
  • The one exception here are aimed shots, whose frames in KQM are from start until shot release. Since aimed shots are usually not dash/jump cancelled, these require special attention.
• For skill/bursts that do involve a hit, KQM frames are until the hitmark, so they will tend to run fast.
• For skill/burst frames that do not involve a hit during the main animation (e.g., Barbara, Venti), KQM frames are until the end of the animation and so are usually decently accurate.

The sim running a bit fast is therefore partially a result of skill/bursts with hits having missing ending animation frame data. This will however take a significant amount of time to fix.

The current proposed plug solution is to add a delay parameter so users can add a custom delay to the end of animations. See #206

[k0l11]

Videos to count/implement/waiting to go live are marked with (c+i)/(i)/(w) (can't guarantee that these markers are up-to-date).

playlist

for certain N1 -> CA cancels please refer to this video instead for certain Burst cancels please refer to this video instead

Traveler: Traveler (Shared, Aether) frames Traveler (Shared, Lumine) frames Traveler (Anemo, Aether) frames Traveler (Anemo, Lumine) frames Traveler (Geo, Aether) frames Traveler (Geo, Lumine) frames Traveler (Electro, Aether) frames Traveler (Electro, Lumine) frames Traveler (Dendro, Aether) frames Traveler (Dendro, Lumine) frames

Pyro: Amber frames Bennett frames Diluc frames Hu Tao frames (footage courtesy of Vladone ツ#9281) Hu Tao frames v2       Hu Tao NA ➔ CA ➔ D/J - CA frames Klee frames Thoma frames Xiangling frames       Xiangling N4 hitlag frames (c+i) Xinyan frames Yanfei frames Yoimiya frames

Hydro: Ayato frames       Ayato NX -> CA frames       Ayato E alternative hitmark Barbara frames       Barbara CA hitmark (unused) Candace frames Mona frames       Mona D -> CA frames Nilou frames Tartaglia frames       Tartaglia E cancel frames Xingqiu frames       Xingqiu Q hitmark Yelan frames

Electro: Beidou frames Cyno frames Dori frames Fischl frames Keqing frames       Keqing E Cast ➔ E Recast frames Kuki frames Lisa Dash/Jump frames Raiden frames Razor frames Sara frames Yae frames

Cryo: Aloy frames Ayaka hitmark frames       Ayaka dash hitmark       Ayaka cancel frames Chongyun frames       Chongyun Dash/Jump frames Diona frames Ganyu frames Kaeya frames       Kaeya Dash/Jump frames Layla frames Mika frames Rosaria frames Shenhe frames (special thanks to Xreejan#1180) Qiqi frames       Qiqi Dash/Jump frames

Anemo: Faruzan frames Heizou frames Jean frames Kazuha frames       Kazuha N5 hitlag frames Sayu frames Sucrose frames       Sucrose CA hitmark Venti frames Wanderer frames Xiao frames       Xiao Dash/Jump frames

Geo: Albedo frames (special thanks to Xreejan#1180) Gorou frames Itto frames Ning frames Yun Jin frames       Yun Jin Dash/Jump frames Zhongli frames       Zhongli N5 frames

Dendro: Alhaitham frames Baizhu frames Collei frames Kaveh frames Kirara frames Tighnari frames       Tighnari CA frames Nahida frames Yaoyao frames

frame counts: Barbara from phaZZi#6461: https://docs.google.com/spreadsheets/d/1R_OywCjjSW8PeYPPniBLVnoTZ8uQ2L_GLKYmQvFTHV0/edit?usp=sharing Diluc: https://docs.google.com/spreadsheets/d/1p0blrnuM7JvwU2QMdZdLayYqP3-7OMDgYC6GDQNn_QU/edit?usp=sharing Keqing: https://docs.google.com/spreadsheets/d/1GAeBzMr0XX89azZhpbjEqPfehgruwI3__GlfEgQ1VvA/edit?usp=sharing Xiao: https://docs.google.com/spreadsheets/d/1WHJy9UjCQY0AO32yluJMhX_ecGO1KGb6SjbOZt9VJDg/edit?usp=sharing Lisa (video by ArchedNosi#1484): https://docs.google.com/spreadsheets/d/1KRt6I_c5qeUQVXcHv7ZOZKdqjn4Z_VN1OyVFvhDumOc/edit?usp=sharing Chongyun: https://docs.google.com/spreadsheets/d/13TsDRmuHCrXBKlka-huhKt1xtjNHhLEZIuJJzj1OQvg/edit?usp=sharing Diona: https://docs.google.com/spreadsheets/d/178Y92g19FlBIb1hIPHKvjByk_NztZ7854pjkkt4fEV4/edit?usp=sharing Kaeya: https://docs.google.com/spreadsheets/d/11f_FxKhXFpL4EHSfFHPPjhXJvVOTi-FP_R6cqaZ9dwo/edit?usp=sharing Qiqi: https://docs.google.com/spreadsheets/d/1uS_n16mlfdfzjBiVG3w6TmR9H7YqSSFOoyox_9bn-Kk/edit?usp=sharing Albedo: https://docs.google.com/spreadsheets/d/1WIejtwUZpZ2lqTNlK2_6cJPoDe0PUmCL6QKB05m_AQQ/edit?usp=sharing Yun Jin: https://docs.google.com/spreadsheets/d/1rDQZ8TJd6JAzD3C6pg_JZrgkYr-LIp36mmXE8XVMj4s/edit?usp=sharing Kazuha: https://docs.google.com/spreadsheets/d/1uEbP13O548-w_nGxFPGsf5jqj1qGD3pqFZ_AiV4w3ww/edit?usp=sharing Yelan: https://docs.google.com/spreadsheets/d/1k4f8EkgneV_588EpJlDavx_0zyFi5ZiWd0HdUV6wx38/edit?usp=sharing Klee: https://docs.google.com/spreadsheets/d/1cRHRn2iR8knyzcioUGGoMFNZgaNJQdlpkUqjeIPowCM/edit?usp=sharing Hu Tao v2: https://docs.google.com/spreadsheets/d/1KR_FMtupIbLEhWRGww2N2UKEJG3hy5mWJIez8S6EZ2w/edit?usp=sharing Mona: https://docs.google.com/spreadsheets/d/1fCdmkNZ6vXmqiOmk6s0Q8AQFzOQt_UjltspbMyDrx4A/edit?usp=sharing Kuki: https://docs.google.com/spreadsheets/d/1cXejpod69F6HReq6jztxEvlpVzSGKssz5NNHIzqY4QY/edit?usp=sharing Heizou: https://docs.google.com/spreadsheets/d/1SsXniQztelJOBWMYPT-w6wygSFkduWhu2OAVC9IUbbA/edit?usp=sharing Razor: https://docs.google.com/spreadsheets/d/1Rceie6ATwNDSbnmIIKgZa1cVtXlBZE6earpJb42SHAM/edit?usp=sharing Itto: https://docs.google.com/spreadsheets/d/13ad3uH2DazxotwjQE6qvWRfcQJpmhkxN4nsbc3vUx78/edit?usp=sharing Aloy: https://docs.google.com/spreadsheets/d/11uyES6x6UFGm2bqcsY4dPSqLgsELrdkPv145NmMwTmc/edit?usp=sharing Amber: https://docs.google.com/spreadsheets/d/1XDS-RP7G7-htZ4PP9A5SXPbg7Gy-Laksp4oXwObNgf8/edit?usp=sharing Gorou: https://docs.google.com/spreadsheets/d/15eKpg9ii86ufny24TEZgzWT0xQbzmIfMUCA2fktuaB4/edit?usp=sharing Sayu: https://docs.google.com/spreadsheets/d/1vLH6ZiAhb7G-f5ecYy-sPLoCdouA5krMixtgh9ITX2Q/edit?usp=sharing Thoma: https://docs.google.com/spreadsheets/d/1QtllZ_QKQIJNGnD4FILZCB307aA8YtDfpG6pcYndl5E/edit?usp=sharing Xinyan: https://docs.google.com/spreadsheets/d/1Wz7gtnavp5pzNjSFidi0EFluZ4E8CoaogvzOXSEF3-E/edit?usp=sharing Sara: https://docs.google.com/spreadsheets/d/1B29Zceb_pl8FYfHtIrZeMttZtovmwE8tHEZud_kkbmo/edit?usp=sharing Ning: https://docs.google.com/spreadsheets/d/12y2e2JkN55UOpbMeTpx1EmqqN9zdfPf3jLLpo9YKxnE/edit?usp=sharing Yanfei: https://docs.google.com/spreadsheets/d/1NslqbafUoW4rhl1D2oVeSsn0SXfvAwnxAlIlwvKY_5Q/edit?usp=sharing Yae: https://docs.google.com/spreadsheets/d/1G8_pp_NFtM1wteo_xRZaG-lTcS3NZ1vADVmjFFp_SOk/edit?usp=sharing Traveler (Shared, Aether): https://docs.google.com/spreadsheets/d/186FpS4ckDENVY4U60xxgevJZj_vdyYWZroIa7P_yDr4/edit?usp=sharing Traveler (Shared, Lumine): https://docs.google.com/spreadsheets/d/1S7cJszsMoQF6ShCvA7hMjiXMuOCoDRwgW1rseP0uC8k/edit?usp=sharing Traveler (Anemo, Aether): https://docs.google.com/spreadsheets/d/1y_KoAchtrWwPDradqLvkKuPbLUonsP9G4aFuuxtxAgg/edit?usp=sharing Traveler (Anemo, Lumine): https://docs.google.com/spreadsheets/d/1QCtYnC_qdrCYwN5qDJLYYGuvx81z9fTGNzPdZ8H4nrU/edit?usp=sharing Traveler (Geo, Aether): https://docs.google.com/spreadsheets/d/1I81WBTsNgyBG8Z9eYjHBSVAn-dGk-dkBIoib5Yp4e4M/edit?usp=sharing Traveler (Geo, Lumine): https://docs.google.com/spreadsheets/d/1IQWPPH4rVSe9fvy2hpvufS1xi7Ni_jfZ7SL4aSudPuM/edit?usp=sharing Traveler (Electro, Aether): https://docs.google.com/spreadsheets/d/1QNQwbrySIw6pY3rvmj-SB5dIEgUHWNz1q5zDbQrnwBo/edit?usp=sharing Traveler (Electro, Lumine): https://docs.google.com/spreadsheets/d/1FRagiZK5WkPiqF6aMea8A1YL0XSxbtGOi-oF8MaG7U4/edit?usp=sharing Tartaglia (Recount): https://docs.google.com/spreadsheets/d/1TDAItxWT_p76Z84EMpk2oIAN2etTWR0DiubllnWBnbc/edit?usp=sharing Zhongli N5 frames: https://docs.google.com/spreadsheets/d/19dQSj8Y8LJ_2kLgWKPlkNp9y7sqvFiquO5h03R2YNXI/edit?usp=sharing Tighnari: https://docs.google.com/spreadsheets/d/1rECAO_yOwB4sDJ70z75pJr6fQsQjx5kgsOWtylcAGLk/edit?usp=sharing Collei: https://docs.google.com/spreadsheets/d/1BHJW5zmHoPWUF_tAhCZRTrU-3Z9dZCvxrsiEJM24wOY/edit?usp=sharing Traveler (Dendro, Aether): https://docs.google.com/spreadsheets/d/1ufLdNaAkmLgYZdgN8kKITU_e0iX1OpDI5Mk-dNnMmg8/edit?usp=sharing Traveler (Dendro, Lumine): https://docs.google.com/spreadsheets/d/1TZvQVhI4o7JbSep8bRVWTVrU7KHVa_hr4T6cvdAq4_0/edit?usp=sharing Cam Cancel vs. Normal Burst Frames: https://docs.google.com/spreadsheets/d/1zCwdd6_KYFqMD4OQ_llGLdDshoZTu_1pmAMysxGDQvs/edit?usp=sharing Dori: https://docs.google.com/spreadsheets/d/1F7mZ269IdPtu0JogHnnUdewG11g2rq3-2KWj5m2BbBY/edit?usp=sharing Candace: https://docs.google.com/spreadsheets/d/1ZzXEM18EpmZcffzbVZNghpR7xrA39ypWwO1BTtiAQzc/edit?usp=sharing Cyno: https://docs.google.com/spreadsheets/d/1BxBymOtw3To2lE7OfNiM5xQO-nkY_IKwvfTSCOFbqC0/edit?usp=sharing Nilou: https://docs.google.com/spreadsheets/d/1z0v3NT1o1iNrVppT_S0C542YDo6jhdKShLcPsnavfO8/edit?usp=sharing Nahida: https://docs.google.com/spreadsheets/d/1MBeFddkD4OtHdBMncqW_j18NC-lUMqA9noVo_pH26H0/edit?usp=sharing Layla: https://docs.google.com/spreadsheets/d/19ZO_rbo6V2n-yWVjM8LqN1lGT2aKoQCbdjB_RX__InY/edit?usp=sharing Faruzan: https://docs.google.com/spreadsheets/d/1sdhP2n26JZvlDZX6k8CoFNJrzNcF29GVjH67P9_aF7w/edit?usp=sharing Wanderer: https://docs.google.com/spreadsheets/d/1UaDmefkw0AsA-sV1oc6Ya4SYRUZEv_deExY4H30RV4U/edit?usp=sharing Alhaitham: https://docs.google.com/spreadsheets/d/1qznqZMkFRRFKpzEXvQ_bJAXoleI2BrV-nKNAusJoYrU/edit?usp=sharing Yaoyao: https://docs.google.com/spreadsheets/d/1A28CI10iM5URyU8PIH8fo99C8ksnUIINevzC28W4ml4/edit?usp=sharing Mika: https://docs.google.com/spreadsheets/d/1lSisZA6gmkq6bOBY3NHyqgiyvZfXEYFwAhVrmqiN7xo/edit?usp=sharing Baizhu: https://docs.google.com/spreadsheets/d/1u74NvNfOgKS6B0cZYOFUArqA133Kqjr3bjT-KXKUMq0/edit?usp=sharing Kaveh: https://docs.google.com/spreadsheets/d/1VV2OOrtPetZg13YuoNutaqHXkB39ZPaseaI3CTHuM7M/edit?usp=sharing Kirara: https://docs.google.com/spreadsheets/d/1elfdm19X1n45ScqZ3UODi_aulOvGtxUycyLWZm5tyeU/edit?usp=sharing

[kurt22i]

I will be updating this comment with the frame counts I do.

from Koli's videos: Ayaka: https://docs.google.com/spreadsheets/d/1WPxQ7vf0_dp5g96aqGF0_JZSqjtYHOJC0b89zRS_WrA/edit?usp=sharing Venti: https://docs.google.com/spreadsheets/d/1wjNpI530VwWX8PtmAA7ZZex5FurVpItfu6jmRQsMcaw/edit?usp=sharing Xingqiu: https://docs.google.com/spreadsheets/d/1eJDOj2mI3tFSM7ii6hn3E9GLtS6ah5GwCISDyb2i304/edit?usp=sharing Ganyu: https://docs.google.com/spreadsheets/d/1PDHCZKh-7eWpbE1b0OyQUCzSPHcViYZ22EDEItjiU7Y/edit?usp=sharing Ayato: https://docs.google.com/spreadsheets/d/1VL6nQvehIj8wTFC6ACC88p3i8lGUZnZV8Lx0G1dZp88/edit?usp=sharing Jean: https://docs.google.com/spreadsheets/d/1KQB8VOEyaCsRa3QulF-gAq3a1CxsqiauTNYuK2_paMY/edit?usp=sharing Sucrose: https://docs.google.com/spreadsheets/d/1qHFGd5xt2MNBCIw7WK78lwv2Az98vLz8CRILU8piugo/edit?usp=sharing Hu Tao: https://docs.google.com/spreadsheets/d/1azK_EOOxyNUPlowg6qY9VeINTNwS2cPQoPcnd9UqFUo/edit?usp=sharing Raiden: https://docs.google.com/spreadsheets/d/1ayeS2Yp32dbdVR-xqSyIeSk7CUDuIFSO6A8XrRCRNgY/edit?usp=sharing Rosaria: https://docs.google.com/spreadsheets/d/1buBVBvlgfNcRA09XA3BLm-oA7hpCVRYkGt_7kPBYJu0/edit?usp=sharing Childe: https://docs.google.com/spreadsheets/d/1iBcJqVG3uWhwyHwCbYQby0mdaLZJ_ZhJCo0I4djnsU8/edit?usp=sharing Bennett: https://docs.google.com/spreadsheets/d/1xjUpc3yUcpqaioep250lfxlpK-feDbdrBmD0TuvBcoA/edit?usp=sharing Fischl: https://docs.google.com/spreadsheets/d/1Pbp9BY1HZIs_iPJdkR3B7WjLMO9iIjWP8tM7NNnp0bU/edit?usp=sharing Zhongli: https://docs.google.com/spreadsheets/d/1NPOothWseChb-OzOHQqunBdi-M3udmQPqPop0kf7H-w/edit?usp=sharing Xiangling: https://docs.google.com/spreadsheets/d/1tWMpn1M34w0rCutUQ5cem28fIVoFVp7YjOXtIm2Rvow/edit?usp=sharing Beidou: https://docs.google.com/spreadsheets/d/1r8fwU2wMBbZsy5fqqSSf8aLvX8aFvJCvaDD8P3Lr2sI/edit?usp=sharing Yoimiya: https://docs.google.com/spreadsheets/d/1DYYiGSNeFekVt3eQQC_MujkLCd_8rgPIIlpPNvwHKTA/edit?usp=sharing

[srliao]

https://docs.google.com/spreadsheets/d/1BdWsPgnZFJ2xFmKgYevvBXYQeDqOLaPpL_VsFzjjiiI/edit?usp=sharing xingqiu frames sheet. currently only 1 trial each (in future counts I will do 3) and not all combos tested, let me know how much more needs to be done before opening a pr.

more chars: Bennett: https://docs.google.com/spreadsheets/d/1wzaBId5I0wxqlikpdZZlXaXRDuCykbdn4izbK__OHss/edit?usp=sharing Xiangling: https://docs.google.com/spreadsheets/d/1lWpwV9RVKsk9X3ghww7ooujxJsonfqC9krWzrXffv3c/edit?usp=sharing

ideally we get to 3 samples but I'll start coding these in as soon as I get the chance to

[kurt22i]

used koli's video to implement ayaka frames here, macro footage really does make this process a lot easier

[srliao]

#447 updates noelle but missing:

attack -> charge attack -> walk charge -> x

[srliao]

all done (for now until tomorrow) :) this is also tracked in docs as well