4 NO Implementation Check

[Tsym-or-Tysm]

The 4 NO set piece bonus appears to have a non-intuitive implementation.

https://github.com/genshinsim/gcsim/blob/main/internal/artifacts/noblesse/noblesse.go

According to srl (https://discord.com/channels/845087716541595668/886303126242623540/931386583423258654)

oh boy.... i should have documented this... there was some really weird interaction with no4
hmm i think it's buried deep in the tcl somewhere....
oh i think it was something like, if one is already active, the next one will not extend the duration as you might expect 
and then there's some weird scenarios

But there doesn't appear to be any indication of this in the KQM library, and the Wiki states that the duration is refreshed. https://library.keqingmains.com/evidence/equipment/artifacts#noblesse-oblige https://genshin-impact.fandom.com/wiki/Noblesse_Oblige

Should confirm and update... at some point eventually maybe...

[jordanlovato]

Perhaps the original concern is a reference to this library entry? https://library.keqingmains.com/evidence/general-mechanics/bugs#noblesse-oblige-4pc-bonus-not-applying-to-some-bursts (EV#1)

I think that EV#1 is a simplified hypothesis of this library entry: https://library.keqingmains.com/evidence/equipment/artifacts#noblesse-oblige (EV#2)

The spreadsheet provided in EV#2 gives me the sense that the sim should switch by character and snapshot/not snapshot the buff for the burst that procs it depending on that character context.

I'm still very green to this repo, so apologies if my understanding is too naïve here. I'm looking for a ticket to dip my toes into the project, and stumbled on this one.

[HanSeoulOh]

Rosaria Burst is not snapshotting the noblesse buff, potentially because of the snapshot delay on the burst.

https://viewer.gcsim.app/share/EC5UmgbofQtMTlPjKav_A for reference Rosaria uses burst at f226, first hit queued at f290, NO4 buff and status is only started at f300. Is this normal? May have to do with PostBurst event.

[HanSeoulOh]

I'm still very green to this repo, so apologies if my understanding is too naïve here. I'm looking for a ticket to dip my toes into the project, and stumbled on this one.

Hey @jordanlovato, if you would like to find tickets to get into, I have labelled a couple as good first issues which might be easier to get into than this one and are lower hanging fruit. Happy to help you get into them if you are in the discord.

[srliao]

Perhaps the original concern is a reference to this library entry? https://library.keqingmains.com/evidence/general-mechanics/bugs#noblesse-oblige-4pc-bonus-not-applying-to-some-bursts (EV#1)

I think that EV#1 is a simplified hypothesis of this library entry: https://library.keqingmains.com/evidence/equipment/artifacts#noblesse-oblige (EV#2)

The spreadsheet provided in EV#2 gives me the sense that the sim should switch by character and snapshot/not snapshot the buff for the burst that procs it depending on that character context.

I'm still very green to this repo, so apologies if my understanding is too naïve here. I'm looking for a ticket to dip my toes into the project, and stumbled on this one.

So the other issue here is how NO interacts when there are multiple NO holders. That's what was originally being asked about here.

I can't find it at the moment but I'm pretty sure there was a ticket in KQM or documentation somewhere on the weird interact where if NO4 is already triggered by one char, another char's NO4 will not extend the duration (and some other weird stuff)

[jordanlovato]

I'm still very green to this repo, so apologies if my understanding is too naïve here. I'm looking for a ticket to dip my toes into the project, and stumbled on this one.

Hey @jordanlovato, if you would like to find tickets to get into, I have labelled a couple as good first issues which might be easier to get into than this one and are lower hanging fruit. Happy to help you get into them if you are in the discord.

That would be super helpful, poke me warbear#3252

[k0l11]

relevant sheet (updated up to 2.1 first half, so everything later starting with Kokomi is not included): https://docs.google.com/spreadsheets/d/1jhIP3C6B16nL1unX9DL_-LhSNaOy_wwhdr29pzikpcg/edit#gid=0