gcsim
gcsim copied to clipboard
Prototype Rancour passive limited to 1 stack
Right now it's only possible to have one Rancour stack.
Here's a simple sim to illustrate the issue.
Example sim
jean char lvl=90/90 cons=0 talent=9,9,9;
jean add weapon="prototyperancour" refine=5 lvl=90/90;
target lvl=100 resist=.1 hp=1000000000;
energy every interval=480,720 amount=1;
active jean;
print(.jean.stats.atk%);
for let i = 0; i < 5; i = i + 1 {
jean attack:1;
print(.jean.stats.atk%);
}
Running it will lead to the following debug output:
I assume the issue is the following line, which resets the stacks if the passive is active rather than when it first gets activated. https://github.com/genshinsim/gcsim/blob/e7023fb909edb67c33c25df8324186d48f21e55f/internal/weapons/sword/prototype/prototype.go#L58
Changing it to !char.StatModIsActive(buffKey)
seems to solve the problem.