implementation of some percentage based buffs is wrong

[k0l11]

https://www.hoyolab.com/article/503042 tldr; buffs that transform attribute 1 into a certain amount of attribute 2 based on a % of attribute 1 are not allowed to use % based buffs to attribute 1 in the calculation of the amount of attribute 2

related: #971

complete list up until and including 3.4: buffs that don't consider banned buffs (attribute type of the banned buff is listed):

• [X] Emblem of Severed Fate Burst%: ER
• [X] ~~Dori A4 energy gain: ER~~ shadow fixed
• [x] Itto Q ATK: DEF
• [X] Kazuha A4 Pyro%/Hydro%/Electro%/Cryo%: EM
• [X] Mona A4 Hydro%: ER
• [X] Nahida A1: EM
• [x] Noelle Q ATK: DEF
• [X] Raiden A4 Electro%: ER
• [x] Raiden A4 Energy Restoration: ER
• [X] Rosaria A4 CR%: CR%
• [X] Sara A4 energy gain: ER
• [X] Sucrose A4 EM: EM
• [x] ~~Tighnari A4 DMG%: EM~~ was fixed to work for sure
• [x] ~~Traveler (Dendro) A4 DMG%: EM~~ was fixed to work for sure
• [X] Traveler (Electro) A4 ER: ER
• [ ] Xingqiu E DMG reduction (which is technically DMG%): Hydro% (not implemented)
• [ ] Xinyan C6 ATK: DEF (not implemented)
• [x] ~~Hunter's Path DMG%: EM~~ was fixed to work for sure
• [X] Wandering Evenstar self/shared ATK: EM
• [X] Makhaira Aquamarine self/shared ATK: EM
• [X] Engulfing Lightning ATK: ER
• [X] Staff of the Scarlet Sands non-stack/stack ATK: EM
• [X] Xiphos' Moonlight self/shared ER: EM

banned buffs:

• [X] Bennett Q ATK
• [X] Hu Tao E ATK
• [X] Itto Q ATK
• [X] Kazuha A4 Pyro%/Hydro%/Electro%/Cryo%
• [X] Kokomi C6 Hydro%
• [X] Mona A4 Hydro%
• [x] Nahida A1 EM
• [ ] Nilou A4 Bloom DMG% (blocked by #913)
• [X] Nilou C6 CR%/CD%
• [X] Noelle Q ATK
• [x] Raiden A4 Electro%
• [X] Rosaria A4 CR%
• [X] Sara ATK
• [X] Sucrose A4 EM
• [X] Traveler (Electro) E/A4 ER
• [ ] Xinyan C6 ATK (not implemented)
• [x] Yaoyao C4
• [X] Wandering Evenstar self/shared ATK
• [X] Makhaira Aquamarine self/shared ATK
• [X] Staff of Homa >=50%/<50% ATK
• [X] Staff of the Scarlet Sands non-stack/stack ATK
• [X] Key of Khaj-Nisut self/shared EM
• [X] Xiphos' Moonlight self/shared ER

Most of them got fixed in #1302.