gcsim icon indicating copy to clipboard operation
gcsim copied to clipboard

bloom related calc logs are missing values

Open k0l11 opened this issue 2 years ago • 0 comments

The Attack() function of dendro cores doesn't call calc(), which leads to the calc logs being pretty much useless to check whether the dendro core dmg (bloom/hyperbloom/burgeon) shown is correct.

attack() calls the Attack() function of the target: https://github.com/genshinsim/gcsim/blob/97e8e28c0e21004127ac33dddc62faa91331fff7/pkg/core/combat/attack.go#L66 target version of Attack(): https://github.com/genshinsim/gcsim/blob/97e8e28c0e21004127ac33dddc62faa91331fff7/pkg/enemy/attack.go#L59 bloom version of Attack(): https://github.com/genshinsim/gcsim/blob/97e8e28c0e21004127ac33dddc62faa91331fff7/pkg/reactable/bloom.go#L121

grafik

k0l11 avatar Oct 17 '22 18:10 k0l11