api icon indicating copy to clipboard operation
api copied to clipboard

FIX #281 Inconsistency in case types( camelCase and snake_case) in characters api

Open Thiru-kumaran-R opened this issue 1 year ago • 2 comments

FIX #281 ,resolved inconsistency issue in casing in all json file in characters including 'add_type_to_character.js' and 'add_weapon_type.js'

Thiru-kumaran-R avatar Jun 05 '24 12:06 Thiru-kumaran-R

I don't think it's a good idea to change attributes that someone's app may already depend on. If anything, I'd delete those attributes completely (still a bad idea) because they are duplicates of "vision" and "weapon"

man90es avatar Jun 05 '24 12:06 man90es

They aren't duplicates. Notice that visionKey and weaponType are always (mostly so pt translations which can be fixed) in english while vision and weapon are in a specific language. So they are entirely useless.

majkus522 avatar May 14 '25 07:05 majkus522