genshin-wishes-api icon indicating copy to clipboard operation
genshin-wishes-api copied to clipboard

startTime and endTime of some banners is wrong

Open KeyPJ opened this issue 2 years ago • 2 comments

I use some api of GenshinWish to make a simple page but startTime and endTime is not all correct for example:

//api/public/banners/character
[
  {
    "id": 100007,
    "version": "2.6.1",
    "start": "2022-03-30T02:00:00",
    "end": "2022-04-14T16:59:00"
  }
]

in fact,the end is 2022-04-19

KeyPJ avatar Apr 20 '22 14:04 KeyPJ

Hi thanks for reporting the issue. It's corrected for the specific banner you mentioned. Did you noticed other incorrect start or end times on other banners ?

We try to be the more accurate as possible but there can be a small difference between the API result and the real start date (few hours for minor updates and up to 6 hours for major updates)

jvergerolle avatar Apr 20 '22 15:04 jvergerolle

FandomWiki is corrent

I can get all the end time and start time by the js code,but i still need to compare them manually

[...new Set([].slice.call(document.querySelectorAll('tr > td:nth-child(3)')).map(a=>a.getAttribute('data-sort-value')))].sort()

just compare date

store wiki data as global variable all store response date as as global variable temp1

temp1.filter(a=>{const{start,end}=a ;return !all.map(a=>a&&[...(a).match(/(\d{4}-\d{2}-\d{2})/g)].join('')).includes(`${end.substr(0,10)}${start.substr(0,10)}`)}).map(a=>a.version)

I get the incorrect banners

character ['2.5.1', '2.4.1', '2.3.1', '2.1.1', '2.0.1', '1.6.1', '1.5.1', '1.3.3', '1.2.2', '1.1.2', '1.0.2', '1.0.1'] weapon ['2.5.1', '2.4.1', '2.3.1', '2.1.1', '2.0.1', '1.6.1', '1.5.1', '1.3.2', '1.2.2', '1.1.2', '1.1.1', '1.0.2', '1.0.1']

KeyPJ avatar Apr 20 '22 16:04 KeyPJ