genn icon indicating copy to clipboard operation
genn copied to clipboard

Improve SynapseGroup documentation

Open neworderofjamie opened this issue 7 months ago • 1 comments

As found by #68, SynapseGroup.out_post isn't documented and neither are SynapseGroup.src or SynapseGroup.trg . As a minimum, should be added to docstring at https://github.com/genn-team/genn/blob/master/pygenn/genn_groups.py#L319

neworderofjamie avatar May 20 '25 08:05 neworderofjamie

Greeting @neworderofjamie

I’m Sahil Kumar. I’d like to open a documentation-only Draft PR to address #68 by adding clear, authoritative docs for SynapseGroup.src, SynapseGroup.trg, and SynapseGroup.out_post in pygenn/genn_groups.py.

Planned deliverables

  1. NumPy-style docstrings for src, trg, out_post: one-line summary, accepted types/shapes, defaults, and runtime side-effects.

  2. Quick local Sphinx build check to confirm the API pages render correctly.

  3. Parameter validation notes in docstrings: what the code accepts vs. what will raise.

  4. Edge-case examples ( scalar vs per-synapse arrays) so contributors don’t guess behavior.

  5. Cross-references: short links in docstrings to related classes/APIs ( SynapsePopulation, model run flow).

  6. Performance note: brief note if e.g., using large per-synapse arrays affects memory.

  7. PR checklist included in the PR description for maintainers: “docs-only”, tests run, Sphinx verified, ready for review.

  8. Small, single-commit branch: docs/synapsegroup-docs and PR titled docs: document SynapseGroup.src/trg/out_post (fix #68).

No runtime behavior changes — docs, tiny tests, and small hygiene fixes only.

If this looks good, please assign me to the issue or reply “go ahead” and I’ll open the Draft PR.

Sahilll10 avatar Oct 24 '25 19:10 Sahilll10