Gengliang Wang

Results 113 comments of Gengliang Wang
trafficstars

Seems quite minor. The catalyst expressions are not public to users either (https://spark.apache.org/docs/latest/api/scala/org/apache/spark/sql/index.html). I am +0 on this one.

cc @hwchase17 @vowelparrot @skcoirz

Hi @dev2049, I have addressed your comments. Could you take another look?

Created a new PR which doesn't inherit from SQLDatabase: https://github.com/hwchase17/langchain/pull/4602 I am closing this one for now.

cc @vowelparrot @hwchase17 @mengxr

Note: There was an approach based on `SQLDatabase`. But @dev2049 suggests not inheriting from SQLDatabase. https://github.com/hwchase17/langchain/pull/4381

@skcoirz Thanks for help updating this one!

cc @vowelparrot @hwchase17 could you review this one? The new agent is helpful for the Apache Spark community.