geneweb icon indicating copy to clipboard operation
geneweb copied to clipboard

Rpc datalist using search-engine

Open a2line opened this issue 1 month ago • 3 comments

a2line avatar Nov 26 '25 05:11 a2line

I think we shouldn't commit client.bc.js to Git. It's too large and can change significantly after updating js_of_ocaml. Storing it would bloat the Git history. We could distribute it in the distribution directory instead?

Halbaroth avatar Nov 26 '25 12:11 Halbaroth

Indeed! I told Henry about that this morning: it's a simple temporary solution for tests on Roglo before a "make distrib-rpc" that would copy main.exe + that js in the right dir after they are build. (It was worst yesterday for its size!)

a2line avatar Nov 26 '25 12:11 a2line

I put this draft because we need to think a solution for the exe+js for distribution. I have currently added a client.bc.js minified by hand with terser that is 133 KB (down from 157 KB for the original that comes out of js_of_ocaml). Perhaps we can add a special step in release.ci to create minified js because all runners have node+mnpm. It's a generic problem for our javascripts, not linked to this PR, but the fact this js is generated from ml will add an extra treatment to that post-process to be done.

a2line avatar Dec 10 '25 01:12 a2line

There's now a new Makefile target distrib-rpc to copy the rpc_server.exe and rpc_client.min.js to the distribution directory after target build-geneweb-rpc is done.

a2line avatar Dec 14 '25 15:12 a2line