leftovers icon indicating copy to clipboard operation
leftovers copied to clipboard

Published 20 hours ago • verified publisher icon genevieve

Regional GKE clusters arent listed using current Clusters.List() implementation

Open Alphasite opened this issue 1 year ago • 9 comments

As per the title the current approach of listing cluster per zone misses regional clusters, so we should be using this API which allows listing clusters across all regions (and as a plus this should give a nice perf boost).

I have the relevant changes in my own fork: https://github.com/Alphasite/leftovers (and some cleanup to bump ginkgo and remove the vendor directory since newer go tooling doesn't play extremely well with it).

Alphasite avatar May 10 '23 16:05 Alphasite

Hey @Alphasite! I was in the process of doing those upgrades and cleanup but if you'd like to make an MR for the changes, please do!

genevieve avatar May 10 '23 16:05 genevieve

Would you prefer i do them as separate PRs or is 1 big one ok?

Alphasite avatar May 10 '23 16:05 Alphasite

Could you do two: one for vendor/ginkgo and one for gcp clusters?

genevieve avatar May 10 '23 16:05 genevieve

Sure, thanks! And i'm glad this project is still alive, i appreciate the responsiveness! I was almost tempted to ping @rowanjacobs and ask 😅.

Alphasite avatar May 10 '23 16:05 Alphasite

Done! Created #109 #110 and #111 thank you!

Alphasite avatar May 10 '23 16:05 Alphasite

(If there is anything we can do to help, please let me know)

Alphasite avatar May 10 '23 17:05 Alphasite

Resolved in #111 (Is the convention to leave an issue open until its fix is merged or released?)

Alphasite avatar May 10 '23 19:05 Alphasite

I have some ci work to do to move from concourse to github actions and then I plan to use that to cut a new release. Are you able to use the master branch for your purposes for now?

genevieve avatar May 10 '23 22:05 genevieve

Yeah, it’s not an issue at all, I’m just using a build off main and it’s working great, thank you for looking at it so quickly!

On Wed, May 10, 2023 at 3:43 PM, Genevieve @.***> wrote:

I have some ci work to do to move from concourse to github actions and then I plan to use that to cut a new release. Are you able to use the master branch for your purposes for now?

— Reply to this email directly, view it on GitHub https://github.com/genevieve/leftovers/issues/108#issuecomment-1542899390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGAARPCS73CK7442MKR4LLXFQKZBANCNFSM6AAAAAAX46S2N4 . You are receiving this because you were mentioned.Message ID: @.***>

Alphasite avatar May 11 '23 00:05 Alphasite