noctua icon indicating copy to clipboard operation
noctua copied to clipboard

Make some comments read-only

Open vanaukenk opened this issue 2 years ago • 4 comments

Comments that are automatically added as part of the automatic ontology updates should be read-only.

If not, there is the possibility that they would be mistakenly deleted and we'd lose that information.

vanaukenk avatar Apr 25 '22 15:04 vanaukenk

@vanaukenk if need be we could use a different property for the automatic comments. We could update all the existing ones with SPARQL.

balhoff avatar Apr 25 '22 15:04 balhoff

@balhoff Okay, whatever you think is best to accomplish this. This potential problem occurred to me this morning as I was looking at the Comments in the graph editor and realized it wouldn't be hard to accidentally delete one.

vanaukenk avatar Apr 25 '22 15:04 vanaukenk

I think it would be good to think about this for a moment. Adding another fundamental "type" to the stack may (does) have consequences for the clients. Also, at some level, if we're talking about an immutable series of "comments", it feels like we're moving back towards a narrative history/log stored in the models themselves. It may be better to think about and commit to that, rather than taking half measures.

kltm avatar Apr 25 '22 17:04 kltm

@balhoff From discussions with @kltm we think this issue requires some more discussion and longer range thinking, so it's not a high priority right now and I'll remove the ticket from the active updates project.

vanaukenk avatar Apr 25 '22 19:04 vanaukenk