go-ontology icon indicating copy to clipboard operation
go-ontology copied to clipboard

Missing parent: [GO term] regulation of biological quality

Open ValWood opened this issue 2 years ago • 2 comments

Lots of issues with the "regulation of biological quality" branch, but it seems the best parent for these terms:

GO:0031413 regulation of buoyancy GO:0060378 regulation of brood size

ValWood avatar Oct 04 '22 18:10 ValWood

Both of these should be classified automatically under there, but they have logical definitions that refer to obsolete terms. I would have expected this to be caught in a check; I'll look into it.

balhoff avatar Oct 04 '22 18:10 balhoff

Both of those terms referenced OBA biological attributes that have been obsoleted and moved to PATO. But our 'regulation of biological quality' pattern (https://github.com/geneontology/go-ontology/blob/master/docs/patterns/regulation_of_characteristic.md) specifies 'biological attribute' as the filler range, not any PATO characteristic/quality. For that reason these two terms still don't classify under 'regulation of biological quality'. We can discuss changing the pattern in our upcoming design patterns discussion.

balhoff avatar Oct 07 '22 17:10 balhoff

At the Jan 2021 (?) jamboree we had discussed to obsolete this branch, this is a bunch of phenotypes.

I would be tempted to close this for now, as this is a huge project.

pgaudet avatar Nov 17 '23 09:11 pgaudet

https://www.ebi.ac.uk/QuickGO/annotations?goUsage=descendants&goUsageRelationships=is_a,part_of,occurs_in&goId=GO:0065008&evidenceCode=ECO:0000269&evidenceCodeUsage=descendants

pgaudet avatar Nov 17 '23 09:11 pgaudet

It probably isn't as huge as it seems. Many of these terms just need this parentage removed. That could be a first step. This would be an improvement because it would mean that terms like vasodilation, lactation, lumen formation, ecdysone biosynthetic process, open tracheal system etc etc, would no longer be is_a biological regulation

ValWood avatar Nov 17 '23 10:11 ValWood

Right !

pgaudet avatar Nov 17 '23 14:11 pgaudet