go-annotation icon indicating copy to clipboard operation
go-annotation copied to clipboard

Some relations in the Noctua GPAD are not being converted from labels to identifiers correctly

Open ukemi opened this issue 4 months ago • 10 comments

As part of our QC, @LiNiMGI and I noticed that there are annotations not passing because they have 'invalid' relations in annotation extensions. Here is the list:

Invalid Relation in GO-Property GOREL:0000032 exists_during.
GOREL:0001019 results_in_division_of.
GOREL:0098790 regulates_translation_of. RO:0002232 has_end_location
RO:0002449 directly negatively regulates activity of.

In the Noctua GPAD output, relations are represented by their labels, but in the 'new' GPAD, they are represented by identifiers. I think most of them have been updated (or the policy for their usage has been updated) and the following changes need to be made: GOREL:0000032 exists_during. ---> RO:0002491 (existence starts and ends during) GOREL:0001019 results_in_division_of. ---> RO:0002233 (has_input-new policy and should be changed in the models? Although I can't find any documentation)
GOREL:0098790 regulates_translation_of. ---> deprecated (2 annotations from SynGO. see below) RO:0002232 has_end_location ---> This one is correct, but not in MGI. These extensions are the result of an inference that isn't very useful, but we could add it.
RO:0002449 directly negatively regulates activity of. ----> RO:0002630 (I think this is an incorrect translation of 'directly negatively regulates' See below).

[Typedef] id: regulates_translation_of name: obsolete regulates translation of def: "OBSOLETE. A relationship that holds between a process and a protein coding gene whose translation is regulated by that process." [] comment: Regulation of translation includes processes that regulate the levels of mature mRNA available for translation, as well as direct regulation of the rate of translation. comment: Usage of this relation has been deprecated in favor of 'has direct input'. subset: display_for_curators subset: valid_for_annotation_extension xref: GOREL:0098790 property_value: local_domain BFO:0000015 xsd:string property_value: local_range "PR:000000001 SO:0000673 SO:0000704" xsd:string property_value: usage "Relates a regulatory process or function to the gene whose translation it regulates." xsd:string {xref="GOC:dos"} is_obsolete: true

Annotation in the original Noctua file: MGI MGI:1345138 enables GO:0140678 PMID:15962011 ECO:0000315 20230504 MGI part_of(GO:0045742),directly_negatively_regulates(GO:0060090) contributor=https://orcid.org/0000-0001-7476-6306|noctua-model-id=gomodel:6446bfcb00001000|model-state=production

Annotation in Lori’s import file: Invalid Relation in GO-Property (11:Annotation_Extensions,12:Annotation_Properties): cannot find RO:,BFO: id: RO:0002449 MGI:MGI:1345138 RO:0002327 GO:0140678 PMID:15962011 ECO:0000315 2023-05-04 MGI BFO:0000050(GO:0045742),RO:0002449(GO:0060090) contributor=https://orcid.org/0000-0001-7476-6306|noctua-model-id=gomodel:6446bfcb00001000|model-state=production

ukemi avatar Feb 28 '24 17:02 ukemi