Ariel Gentile

I had the same issue recently when upgrading to react-native 0.69.1. When looking at logcat I noticed that the issue was caused by `java.lang.ClassNotFoundException: Didn't find class "androidx.core.view.MenuHost"`. It turns...

> However when auto accept is not enabled and the external controller would like to decide whether to respond to an incoming message it is not possible to respond. The...

I agree with you about the usage of `pthid` for sub-protocols. Maybe my issue was a bit 'nitpicking' because in other cases, such as [createProposal](https://github.com/hyperledger/aries-framework-javascript/blob/f64a9da2ef9fda9693b23ddbd25bd885b88cdb1e/packages/core/src/modules/credentials/services/CredentialService.ts#L103) method, we are indeed setting...

> > > Kudos, SonarCloud Quality Gate passed!    [](https://sonarcloud.io/dashboard?id=hyperledger_aries-framework-javascript&pullRequest=983) > > > [](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=hyperledger_aries-framework-javascript&pullRequest=983&resolved=false&types=CODE_SMELL)...

I don't see any problem on using an agent creator method, especially considering that we currently need to call `initialize` method after the constructor to make it usable. Could be...

> Yes as berend mentioned it would be possible to override the core module by providing it in the agent config, however the typing is currently set to only allow...

> @TimoGlastra The exact issue which I am facing right now is - Asynchronously errors are being thrown by AFJ in react native env. > > When autoAcceptInvitation is enabled...

> > Why include `android` in the protocol name? Doesn't FCM work with iOS as well? > > Yes Fcm works for iOS as well. However, @TimoGlastra and I had...

I have a few more comments about this after having some fun with FCM on Android and iOS devices: - Notification handling is quite different in both platforms, so maybe...

> How does the client know if the mediator has the app registered in firebase? Seems that having different protocols for apns and fcm (and why not AWS SNS) to...