ecologits icon indicating copy to clipboard operation
ecologits copied to clipboard

Enhance model repository

Open samuelrince opened this issue 1 year ago • 3 comments

Description

The following improvements can be considered :

  • Automatically synchronize local file with remote (right now a GitHub URL)
  • Have the model repository follow its own release cycle
  • Handle alias instead of duplicating models
  • Support dynamic fields based on the model type

Solution

A separate repository that builds the file that is then injected in the client build?

Considerations

Any input is welcome.

Additional context

See more context here https://github.com/genai-impact/ecologits.js/issues/4

samuelrince avatar Jul 04 '24 18:07 samuelrince

Hi @samuelrince, just wanted to highlight one thing I observed - the ModelRepository.from_csv() is loading the CSV file from disk each time it's called (code here), which is slowing down it's performance due to the increased disk I/O.

We can probably consider making the ModelRepository a singleton class, so ModelRepository.from_csv() will load the CSV from disk only the first time and return the same every time it's called. This will also increase it's performance due to much lesser disk I/O.

P.S.> I came across Ecologits recently and I think it's an amazing project and initiative, kudos to you and all other contributors for the great work! 💚

omkar-foss avatar Aug 08 '24 10:08 omkar-foss

Hello @omkar-foss thanks for the feedback! It will be one of our priority in the following days or weeks. 🙏

samuelrince avatar Aug 09 '24 09:08 samuelrince

That's great to know @samuelrince! Let me know if I can help with any of the action items, would love to contribute.

omkar-foss avatar Aug 09 '24 18:08 omkar-foss