go-unarr icon indicating copy to clipboard operation
go-unarr copied to clipboard

I found bundled C source code for 7z, rar, tar and zip, bzip2, is a concern, maybe out-of-date.

Open rwperrott opened this issue 1 year ago • 4 comments

I looked at this because of surprising unarchiving failures by cbconvert.

I could see "C" references in the Go code, so assume that all of this C code is compiled for use by the Go code.

e.g. The unarrc/external/zlib/README starts with:

ZLIB DATA COMPRESSION LIBRARY

zlib 1.2.11 is a general purpose data compression library.  All the code is
thread safe.  The data format used by the zlib library is described by RFCs

The current zlib version from https://www.zlib.net/ is zlib 1.3.1, January 22, 2024.

It would probably have been smarter to dynamic bind to a 7z library for all the archive types, maybe a maintained Go library already exists for this, or the code could call CLI 7z/7zz, or archive specific CLI programmes.

This smells off.

rwperrott avatar Jul 22 '24 04:07 rwperrott