gempy icon indicating copy to clipboard operation
gempy copied to clipboard

deviation in the CenteredGrid

Open GeorgeLiang3 opened this issue 3 years ago • 0 comments

Describe the bug In Tutorial 2.2: Centered Grid, the centers of the grid are not at the centers, instead, the left and right points are at the midpoints of two adjacent center points. In addition, the resolution and the radius at the moment are actually extended further, which might cause confusion to the users.

Expected behavior So what's originally designed here is the grid centers grow exponentially with respect to the radius. The problem comes from computing the left and right points, where we find the midpoint of the two adjacent centers as the boundary point. However, this will 1) require extending the grids further than what given by the user, e.g. the radius is given by the user is 100, the left-most center is placed at -100, the left side boundary is -100-(grid size). What I think should be better, is to define the left-right sides as the exponential factor, and find the center points. This will keep the resolution and radius provided by the user and also fix the plotting in the example.

Screenshots image

Desktop (please complete the following information):

  • OS: MacOS
  • GemPy Version
    • if cloned from GitHub: provide Git commit id 7085198
  • Jupyter Version (if applicable)

Additional context Add any other context about the problem here.

GeorgeLiang3 avatar Mar 02 '21 14:03 GeorgeLiang3