gempy icon indicating copy to clipboard operation
gempy copied to clipboard

Onlap relations

Open domist07 opened this issue 4 years ago • 7 comments

I try to build a model with Onlap relations, but the cutting of the surfaces isn't as I expect. Here is the picture what GemPy produces: 2020-12-23 10_59_59-PyVista However, according to my imagination, the blue surface should be present as the top layer in the center of the model. There the blue data points are above those of the red layer.

I set the series and their relation with:

gp.map_stack_to_surfaces(geo_model,
                         {"b": 'blue',
                          "r": 'red',
                          "y": 'yellow',
                          "g": 'green',
                          "ba": 'basement'},
                         remove_unused_series=True)

geo_model.series._w.set_bottom_relation(["b", "r", "y", "g", "ba"],
                                        ["Onlap", "Onlap", "Onlap", "Onlap", "Onlap"])

Desktop

  • OS: Windows10
  • GemPy Version 2.2.6
  • Spyder 4.2.0

domist07 avatar Dec 23 '20 10:12 domist07

Hey @domist07,

sorry for the late reply over a month later! Have you been able to find a solution for your issue already? If not I am trying to ping @Leguark to help you out here.

Cheers Alex

AlexanderJuestel avatar Jan 27 '21 07:01 AlexanderJuestel

Unfortunately no. Shall I send you or Leguark the data for replication?

domist07 avatar Jan 27 '21 17:01 domist07

Hey @domist07 sorry for being absent for a month, we had a pressing deadline last week. Mmmm could be due to the order of the series? I always get very confused with what is the expected behavior when we start mixing erodes and onlap :smile:

If the order is not the case just create a test here https://github.com/cgre-aachen/gempy/blob/master/test/test_community_bugs/test_community_bugs.py and make a pull request

Leguark avatar Feb 04 '21 13:02 Leguark

Okay I just made a new release and in principle, it should be fixed just take a look. It still looks weird because there is blue volume on top of the blue and red surface but I think it is the right behaviour.

Also, usually is not a good idea to use restricted methods. Use better:

geo_model.set_bottom_relation(["b", "r", "y", "g", "ba"],
                                        ["Onlap", "Onlap", "Onlap", "Onlap", "Onlap"])

Cheers!

Leguark avatar Feb 05 '21 14:02 Leguark

Thanks @Leguark for the update. Now it looks much better! However, I noticed that if I increase the radius to 200m the result on the northern side still looks weird 🤔 In my opinion, all layers there should be masked by the green one, so that the purple volume covers the whole width. grafik

domist07 avatar Feb 10 '21 10:02 domist07

Is this still an open issue @domist07? Otherwise feel free to close the issue :)

AlexanderJuestel avatar Sep 07 '21 13:09 AlexanderJuestel

What's the status on this issue? @domist07 can we close this?

Japhiolite avatar May 04 '22 09:05 Japhiolite