Robbie Gemmell

Results 66 comments of Robbie Gemmell

There will definitely be no finalizers :) I think the connection is the most likely choice for a shared thing enabled by config.

I didnt say it would be per connection. You asked about lifecycle. Factories dont have any 'close'. Connections do. Hence..

The current/second version isnt quite what I had in mind when it occurred to me the connection executor was already there. You made it a sort of hybrid still mostly...

I think single completion at a time is the way to go, at least by default, it just shouldn't really be a concern when using it whether the callback execution...

Having just read them all, the existing feedback and questions (e.g impact on default case) on the code and in the discussion essentially all still seems to apply now (even...

Can you elaborate on the benefits you measured here? I'd like to understand the extent to consider against the downside of exposing dep impl types throughout the code base. The...

Well again, there are ways that dont require putting them in the URL, including the very one you used to implement the change under the covers. If you are saying...

I dont, as I say I cant really see a reason this would alter the client behaviour at all really, during connection the different routes are essentially the same and...

Can you close the PR, the change looks to have been landed as 9a89ff4ea, minus one removal that was commented on above.