testplane icon indicating copy to clipboard operation
testplane copied to clipboard

cannot find invisibleElements typing in

Open albion9919 opened this issue 5 months ago • 1 comments

Verify latest release

  • [ ] I verified that the issue exists in the latest Hermione release

Hermione version

[email protected]

Last Hermione version that worked

[email protected]

Which area(s) of Hermione are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

NDA

Reproduction steps

install testplane with typescript and try

await this.browser.assertView('..., '...', { ... invisibleElements: ['...'], });

Actual Behavior

After migrating from hermione@8 to tesplane faced some problem with typings:

Typescript shows, that invisibleElements is not defined on assertView

await this.browser.assertView('..., '...', {
                invisibleElements: ['...'],
});

But tesplane works line invisibleElements are used.

We create patch for typings:

diff --git a/build/src/config/types.d.ts b/build/src/config/types.d.ts
index........ ...
--- a/build/src/config/types.d.ts
+++ b/build/src/config/types.d.ts
@@ -13,6 +13,12 @@ export interface BuildDiffOptsConfig {
     ignoreCaret: boolean;
 }
 export interface AssertViewOptsConfig {
+    /**
+     * DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
+     *
+     * @defaultValue `[]`
+     */
+    invisibleElements: string | Array<string>;
     /**
      * DOM-node selectors which will be ignored (painted with a black rectangle) when comparing images.
      *
  1. Is it really bug in typings ?
  2. can you fix this ❤️ ?

Expected Behavior

No typing error

Which Node.js version are you using?

20.11.0

albion9919 avatar Sep 19 '24 08:09 albion9919