gemini icon indicating copy to clipboard operation
gemini copied to clipboard

Supporting choosing any color for HTML report background

Open bruk1977 opened this issue 8 years ago • 5 comments

It would be nice the hmlReporter accepted an argument to set the background... something like:

gemini test --reporter html --htmlBackground #d8f4c8

Thanks

bruk1977 avatar Jan 21 '17 16:01 bruk1977

Hello. Do you know that you can do it via gemini config? Like this:

system:
    diffColor: #d8f4c8

I'm not sure that this option will be really useful. To my mind one constant color for image difference better perceived by the eye than always different colors. Are you agree with me? Or maybe you have some use cases when this option will be really helpful?

DudaGod avatar Jan 23 '17 18:01 DudaGod

Thanks @DudaGod ... I agree with you for a single site having a consistent color make sense... However, if you have multiple sites with different background color (theme) a single color might not work... The scenario I've is we are supporting different themes for different websites and have a central Vdiff tool that is used by these different sites... and wanted to set the background color when I run gemini tests for these different sites. BTW, I am not asking for a diffColor but a background color for the image box. Looks like gemini config doesn't support setting even background color. You can change to certain colors on the UI but would be nice the report has set to a color a user wants to be a default based on the theme of the site.

bruk1977 avatar Jan 23 '17 19:01 bruk1977

Oh, sorry. I don't understand how I read so incorrectly, shame on me =) Okay, now I understand you correctly. And tomorrow we will speak about your proposal. I will keep you posted.

Thank you.

DudaGod avatar Jan 24 '17 21:01 DudaGod

Sorry to keep you waiting.

We had spoken about your proposal and decided that currently we don't have time for implementation this feature =(

But Pull Requests are welcomed. Thank you.

DudaGod avatar Feb 01 '17 06:02 DudaGod

Thanks @DudaGod for your response...

bruk1977 avatar Feb 01 '17 13:02 bruk1977