gemini icon indicating copy to clipboard operation
gemini copied to clipboard

captureElements() and ignoreElements() should capture/ignore all matching elements

Open arikon opened this issue 8 years ago • 9 comments

For now it captures / ignores the first one only.

arikon avatar Jul 27 '15 09:07 arikon

I don't think it should capture/ignore all elements with current API. My proposal is to add some new way to specify that every element matching the selector should be taken into account. For example:

suite.captureElements({every: '.we-need'})
       .ignoreElements({every: '.we-dont-need'})
       .ignoreElements('.we-dont-need-the-first')

SevInf avatar Jul 27 '15 10:07 SevInf

@SevInf Ok

arikon avatar Jul 27 '15 16:07 arikon

/cc @varya

arikon avatar Jul 27 '15 16:07 arikon

M.b. this should be another thread, but the example above (the chaining) would not work, because every ignoreElements overwrites the previous in the suite.

varya avatar Jul 27 '15 19:07 varya

+1 It is strange that method with name ignoreElements really ignore only one element.

tenorok avatar Dec 24 '15 15:12 tenorok

+1

nerevar avatar Dec 24 '15 16:12 nerevar

:+1:

a-x- avatar Dec 24 '15 18:12 a-x-

+1

andysh7 avatar Jun 27 '16 10:06 andysh7

Current state of this issue:

  • [x] ignoreElements
  • [ ] setCaptureElements

Dmitriy-kiselyov avatar Mar 29 '18 15:03 Dmitriy-kiselyov