oq-hazardlib icon indicating copy to clipboard operation
oq-hazardlib copied to clipboard

Implementation of Stafford (2014) source-scaling relation

Open pstafford opened this issue 7 years ago • 3 comments

This implementation includes magnitude-to-area relations only and simply replicates the structure of other source-scaling relations already in oq-hazardlib

pstafford avatar Apr 23 '17 20:04 pstafford

Thanks for your contribution. We are happy to accept new MSR classes, but our policy is to have tests for each new feature. You can have a look at this document that gives some instructions to contributors: https://github.com/gem/oq-hazardlib/blob/master/doc/implementing-new-gsim.md. Since you are contributing a new MSR and not a GSIM, for the tests you can look at the existing ones for other MSRs: https://github.com/gem/oq-hazardlib/tree/master/openquake/hazardlib/tests/scalerel

micheles avatar Apr 28 '17 08:04 micheles

I am in the middle of a substantial refactor of the whole MSR library, of which this will be one new addition. A new PR will be opened in due course with everything, including tests added. I recommend to keep this PR open for comment until I have made the refactor and then close it once the code is moved into the new PR.

g-weatherill avatar Apr 28 '17 08:04 g-weatherill

Thanks Graeme for your message. I kindly ask you to coordinate with us for any major refactoring as you are anticipating in your last message. Regarding Peter's PR I would suggests he proceeds with the preparation of tests.

mmpagani avatar May 03 '17 11:05 mmpagani