oq-engine icon indicating copy to clipboard operation
oq-engine copied to clipboard

Published 20 hours ago • verified publisher icon gem

minor fixes in functions implementing Stepp (1972) completeness analysis

Open guyomd opened this issue 2 years ago • 1 comments

Two changes:

  1. added the highest magnitude bin in the analysis, which was missing
  2. propose an improvement in the function to plot Stepp (1972) analysis: the legend was set outside the Axes and labels were consequently truncated on the right

guyomd avatar Oct 05 '22 14:10 guyomd

You need to fix the tests in hmtk/tests/seismicity/completeness/comp_stepp1971_test.py

micheles avatar Oct 05 '22 17:10 micheles

Many thanks, @guyomd. There is one test failing. Pls, let me know if you prefer that we fix it.

mmpagani avatar Oct 15 '22 11:10 mmpagani

Sorry for replying so late. I would indeed appreciate if you could fix the test. Otherwise, I am afraid that it may take me additional delay (i.e. 10 days due to a busy next week) to modify the test appropriately. Thanks a lot.

guyomd avatar Oct 15 '22 20:10 guyomd

Merging and I will fix the test.

micheles avatar Oct 20 '22 03:10 micheles

Merging and I will fix the test.

Thanks Michele. I appreciate.

guyomd avatar Oct 20 '22 06:10 guyomd