gitfiti icon indicating copy to clipboard operation
gitfiti copied to clipboard

Pip support

Open nhumrich opened this issue 8 years ago • 6 comments

This pull request does the following things:

  1. fix bug in ASCII_TO_NUMBER dict
  2. changes formatting for Pep8 compatibility
  3. Adds support for Python3 without breaking python 2.7+
  4. Adds support for pip

You can upload to pip using ./setup.py sdist upload. In order to upload, you will need to change the version __version__ in gitfiti.py. You may want to take the liberty of editing some things in setup.py

I have taken the privileged of uploading this to pypi already. If you send me your pypi username I will pass ownership to you. The readme will have to be updated to show you can install with pip

nhumrich avatar Jun 08 '16 17:06 nhumrich

Would you mind splitting this into two PR's? one for the pip setup addition and the other rebased against master? I merged a previous PR that already cleaned up PEP8 violations and py2/3 support.

Thanks!!!

My pypi username is also "gelstudios".

gelstudios avatar Jun 09 '16 19:06 gelstudios

Thanks for creating the setup script!

Feel free to provide that in a separate PR.

homeworkprod avatar Jun 09 '16 21:06 homeworkprod

updated. This is now just mostly pip support

nhumrich avatar Jun 09 '16 23:06 nhumrich

@gelstudios you are now an owner of the package. Feel free to remove me if youd like.

nhumrich avatar Jun 09 '16 23:06 nhumrich

You might want to add a Trove classifier for Python 3.4 as well.

Thanks for introducing a package, was going to do that later, too. This makes it easier to deconstruct code into several modules.

I assume the test for str_to_sprite will break until adjusted.

homeworkprod avatar Jun 09 '16 23:06 homeworkprod

ok fixed test and added the classifier

nhumrich avatar Jun 09 '16 23:06 nhumrich