geli icon indicating copy to clipboard operation
geli copied to clipboard

Angular 7

Open dboschm opened this issue 5 years ago • 9 comments

Description:

Updated dependancies

Closes #889

Improvements

  • angular 7 and more new dependancies in the frontend
  • updated to new dragula API

Known Issues:

dboschm avatar Feb 09 '19 21:02 dboschm

image https://github.com/geli-lms/geli/pull/1143/commits/4a4c7bc99845fde805e37dfab0677f8928a26e3f

kesselb avatar Mar 26 '19 20:03 kesselb

image

Download dialog looks odd with angular 7

kesselb avatar Mar 26 '19 20:03 kesselb

It's not possible to download any course or assignment with this branch. I fixed the code warnings but ... @dboschm @PatrickSkowronek

kesselb avatar Mar 26 '19 21:03 kesselb

Once you and all of your dependencies have updated to RxJS 6, remove rxjs-compat.

kesselb avatar Mar 26 '19 21:03 kesselb

It's not possible to download any course or assignment with this branch. I fixed the code warnings but ... @dboschm @PatrickSkowronek

<Blob><any>response.body would work. Do you have a better suggestion? The response is already a blob but response.body has another return type. So you have to cast it to any and to blob than.

kesselb avatar Mar 26 '19 21:03 kesselb

npm install -g rxjs-tslint
rxjs-5-to-6-migrate -p src/tsconfig.app.json

image

kesselb avatar Mar 26 '19 21:03 kesselb

<Blob><any>response.body would work. Do you have a better suggestion? The response is already a blob but response.body has another return type. So you have to cast it to any and to blob than.

@kesselb I haven't looked into this too much, but it appears that https://angular.io/api/http/Response is deprecated anyway, and there now is https://angular.io/api/common/http/HttpResponse "including a typed response body", returned by https://angular.io/api/common/http/HttpClient get overload nr. 10 ( observe: 'response', responseType: 'blob' as used in BackendService.getDownload, which in turn is used from DownloadFileService.getFile).

torss avatar Mar 26 '19 22:03 torss

<Blob><any>response.body would work. Do you have a better suggestion? The response is already a blob but response.body has another return type. So you have to cast it to any and to blob than.

@kesselb I haven't looked into this too much, but it appears that https://angular.io/api/http/Response is deprecated anyway, and there now is https://angular.io/api/common/http/HttpResponse "including a typed response body", returned by https://angular.io/api/common/http/HttpClient get overload nr. 10 ( observe: 'response', responseType: 'blob' as used in BackendService.getDownload, which in turn is used from DownloadFileService.getFile).

way better ;)

kesselb avatar Mar 26 '19 22:03 kesselb

Breaking changes from 6.3 to 7.3

https://github.com/angular/material2/blob/master/CHANGELOG.md#breaking-changes https://github.com/angular/material2/blob/master/CHANGELOG.md#breaking-changes-1 https://github.com/angular/material2/blob/master/CHANGELOG.md#breaking-changes-2 https://github.com/angular/material2/blob/master/CHANGELOG.md#breaking-changes-3 https://github.com/angular/material2/blob/master/CHANGELOG.md#breaking-changes-4

kesselb avatar Mar 28 '19 10:03 kesselb