geist-ui icon indicating copy to clipboard operation
geist-ui copied to clipboard

fix(slider): trigger drag event should disabled click event

Open nonzzz opened this issue 3 years ago β€’ 2 comments
trafficstars

Checklist

  • [x] Fix linting errors
  • [x] Tests have been added / updated (or snapshots)
  • [x] Fix Slider trigger drag event can trigger click event cause update value twice time.

Change information

cc. @unix

#774

nonzzz avatar Jul 06 '22 02:07 nonzzz

Deploy Preview for geist-ui ready!

Name Link
Latest commit 8038f00a654d03dea9add15afe3cfda81a4f22c3
Latest deploy log https://app.netlify.com/sites/geist-ui/deploys/62c4efd79960b5000aa23444
Deploy Preview https://deploy-preview-788--geist-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 06 '22 02:07 netlify[bot]

Codecov Report

Merging #788 (8038f00) into master (6e70232) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      198           
  Lines        3046     3049    +3     
  Branches      668      669    +1     
=======================================
+ Hits         3011     3014    +3     
  Misses         34       34           
  Partials        1        1           
Impacted Files Coverage Ξ”
components/slider/slider.tsx 98.70% <100.00%> (+0.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6e70232...8038f00. Read the comment docs.

codecov[bot] avatar Jul 06 '22 02:07 codecov[bot]