geist-ui icon indicating copy to clipboard operation
geist-ui copied to clipboard

[Bug]: The slider component is easy to trigger click events during the dragging process

Open nonzzz opened this issue 3 years ago • 2 comments

Bug report 🐞

Version & Environment

  • Chrome 100.
  • latest version of geist

Expected Behaviour

From the docs we can see , when we drag the dof. It's easy way to trigger click event. It's unreasonable. I think it can be fixed :)

Actual results (or Errors)

From source code. we can add a lock for dragHandler, and add unlock logic for clickHandler.

nonzzz avatar May 26 '22 06:05 nonzzz

Also running into this issue. Is there any news on this PR?

deepfates avatar Jul 20 '22 17:07 deepfates

@deepfates I already fix it. Waiting for the owner to review. :)

nonzzz avatar Jul 21 '22 01:07 nonzzz

adding prop onClick={() => {}} on the slider fixed issue for me

samuelmaker avatar Oct 18 '22 20:10 samuelmaker

adding prop onClick={() => {}} on the slider fixed issue for me Sadly,In my case. I need use onClick too. So the solution doesn't work for me

nonzzz avatar Oct 19 '22 01:10 nonzzz

@nonzzz Understood. Hope you get it resolved

samuelmaker avatar Oct 19 '22 08:10 samuelmaker