cozy icon indicating copy to clipboard operation
cozy copied to clipboard

Redesign book detail view

Open Haaruun-I opened this issue 1 year ago • 3 comments

Should close #945 and #943

This adds a tooltip showing the file name of the chapter when you hover over it, and a fallback image. Also changes out the weird progress ring and labels with a progress bar.

Screenshot from 2024-07-31 09-29-15

Also gives two lines to the title text, instead of just one. And moves the playbutton to the right hand side.

Screenshot from 2024-07-31 09-25-08

Here is it without those two changes, I think the 2 lines look better, but not sure on what side the play button should be on

Screenshot from 2024-07-31 09-23-50

Also adds to the options menu, giving it the same options as in the card + the now renamed download button (greyed out because the option isnt availible, would just be hidden normally)

image

Should the preview card also have the download option? I think it would make sense if the two menus had all the same options

Going to keep this as a draft untill I get feedback on the design

Haaruun-I avatar Jul 31 '24 06:07 Haaruun-I

@DjLizama please don't approve pull requests without actually reviewing it. Thanks!

rdbende avatar Aug 12 '24 15:08 rdbende

Thank you for the review! I think the progress bar works fine on narrower screens, although the rest of the top bar could use a little work.

image

Haaruun-I avatar Aug 12 '24 17:08 Haaruun-I

image

Hmm. Maybe it should display times in the 00:00:41, 10:42:00 format then

rdbende avatar Aug 14 '24 11:08 rdbende

Hi!

Life got busy for a bit, and I kinda forgot that this was left unfinished, sorry.

Here are the changes you asked for.

Haaruun-I avatar Jun 07 '25 18:06 Haaruun-I

image

Just to have a record of this, I find the big progressbar confusing, as there is an other one in the player bar, but they are showing different progresses. There also needs to be more padding between the subtitle and the progressbar/whatever we decide on in place of it.

rdbende avatar Jun 25 '25 21:06 rdbende

Anyway, I'm merging this now, as I'm doing a bigger rework on the code architecture side, and I don't want to deal with merge conflicts.

rdbende avatar Jun 25 '25 21:06 rdbende