Guillaume Lederrey

Results 92 comments of Guillaume Lederrey

Sorry, lots of comments. But yes, this looks good! I'd like to see a few more unit tests (and not just integration tests). Adding unit tests will probably push you...

Thanks for your work! Sorry I send so many comments, don't take it as me being unhappy with what you are doing (on the contrary)!

This still looks good! I can send a pull request on your pull request with some cleanup if you'd like...

Thanks for the report! #666 should fix the issue. Any chance you check it before I merge it?

Those log4j based output writers are problematic in quite a few ways. The main issue is that they introduce a direct dependency on log4j and on log4j internals, causing all...

It seems that the `RateUnit` attribute is causing the issue. I'm not an expert in InfluxDB, but I think it does only support numeric values. `RateUnit=SECONDS` is probably unsupported. The...

I don't have much experience with new relic, but it seems that it relies exclusively on their own agent. It looks like there is a possibility to add [configuration to...

It looks like the config file was changed and that jmxtrans tried to reload it and restart. There is probably a bug in the restart process. To be honest, that...

This does indeed look like a great idea! I'm pretty sure I won't have time to work on it, but feel free to submit a PR!

Ok, I see what you mean. To have a daily rolling index, we also need to configure an [index template](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-templates.html), so that new indexes have the correct configuration. I'm writing...