Error in for loop

[madman9999]

trafficstars

There is an error when you have more than one domain (DNSIDsv4) )to be updated. Only the first ID will be updated, all other will be ignored, because the variable old.ipv4 is updated inside the "for loop", which causes that in the next loop the old.ipv4==new.ipv4.

So please remove line 133 (echo $NEWIPv4 > old.ipv4). I think the same apply for IPv6, but I don't use it.

I put at the end of the script the following lines and it works like this:

if [ ! "$OLDIPv4" == "$NEWIPv4" ]; then echo $NEWIPv4 > old.ipv4 log "IP Address updated to $NEWIPv4" log "###################################################" fi

[alfschauer]

I can confirm: Issue still exists, second IDs won't be updated. You should adapt your script, maybe in the way madman9999 suggested.

[Strubbl]

There are now three solutions to this problem, see #23, #25 and #28

[gehaxelt]

I merged #28, so this should fix the issue?