macos-virtualbox-vm icon indicating copy to clipboard operation
macos-virtualbox-vm copied to clipboard

Script ignores first argument

Open mankoff opened this issue 8 years ago • 3 comments

https://github.com/geerlingguy/macos-virtualbox-vm/blob/c18feb01d4c871f64d908999372b5ae174646ecb/prepare-iso.sh#L148

The script instructions say the first argument is the path to the installer, but it does no use this argument and instead looks for Sierra, then Capitan, then etc. installers. This causes confusion if you have multiple installers including Sierra, but want to run the script on something other than Sierra.

mankoff avatar Aug 12 '17 08:08 mankoff

I've created a PR to fix this and it's on my Github acct, if you're interested.

kylegoetz avatar Mar 20 '18 02:03 kylegoetz

@kylegoetz - Can you file a PR against this issue/project?

geerlingguy avatar Aug 15 '18 15:08 geerlingguy

I have a PR pending for this. Well it's associated with the other issue, but I think they solve the same thing: it uses the params, plus it lets you specify a tmp path if you want to use a path other than /tmp. This was important to me because I didn't have enough space on my laptop's internal drive for all the scratch work, so I added this and did the extraction/etc. on an external drive.

kylegoetz avatar Aug 25 '18 16:08 kylegoetz