internet-pi icon indicating copy to clipboard operation
internet-pi copied to clipboard

Angular deprecation affects 'Node Exporter' Grafana dashboard

Open falkecarlsen opened this issue 11 months ago • 1 comments

https://grafana.com/docs/grafana/latest/developers/angular_deprecation/

falkecarlsen avatar Mar 18 '24 12:03 falkecarlsen

You can change the uptime panel from Statusmap to Status history for a test. Here is an example what I currently have in a modified dashboard.

grafana_status_history

I did also set the Max data points to 365 (no idea what an ideal value is). Otherwise it was choking. Similar to other panels with certain time ranges, where it cannot display data.

At least it still looks similar and ok. But don't know if it is an appropriate one. Will be interesting what @geerlingguy has in mind for a new panel type. 😎

mschirrmeister avatar Mar 27 '24 15:03 mschirrmeister

Seems to be now a problem that breaks this overview: Screenshot 2024-06-01 at 16 49 00

Running grafana/grafana:latest, just pulled and it's the version that was pushed 4 days ago.

martinbrose avatar Jun 01 '24 15:06 martinbrose

fwiw: https://github.com/geerlingguy/internet-pi/issues/598#issuecomment-2141068063

quadespresso avatar Jun 02 '24 23:06 quadespresso

Thanks @quadespresso,

we might just need to raise a pull request to fix this real quick with your interim solution... Do you want to raise one?

Cheers

martinbrose avatar Jun 03 '24 09:06 martinbrose

Sure thing, @martinbrose. Is it just a simple matter of exporting my dashboard?

I'll dig around to see if I can figure out whether it's as straightforward as that, or something considerably less verbose.

quadespresso avatar Jun 03 '24 21:06 quadespresso

fyi my comments here might cross over into #598 (and vice-versa). Adding @mschirrmeister to this thread for visibility. And @butchkemper as well, due to them accepting my suggestion absent additional scrutiny.

So I exported my dashboard and diff'd against https://github.com/geerlingguy/internet-pi/blob/4.0.0/internet-monitoring/grafana/provisioning/dashboards/internet-connection.json and found a fair number of other things have been updated as well.

I'm happy to file a PR with this change. But the PR may well impact other facets of the dashboard, for better or for worse.

I suppose I could phrase it as "2024-06 Internet Connection dashboard update" and include a mention of the plugin update for the Uptime panel plugin? The very nature of "includes other random things you probably didn't ask for" grates against my own sensibilities.

Let me know your thoughts. I can always set up the PR, and we can continue the discussion there.

quadespresso avatar Jun 04 '24 02:06 quadespresso

PR created for discussion: https://github.com/geerlingguy/internet-pi/pull/599

quadespresso avatar Jun 05 '24 00:06 quadespresso

Should be fixed now, let me know if not!

geerlingguy avatar Jun 13 '24 19:06 geerlingguy

Hey Jeff how 'bout fixing your internet-monitoring? I use it instead of internet-pi. I already have a pi running docker compose.

Thanks

Dennis

DWomack avatar Jun 14 '24 23:06 DWomack