Enabled the selection of cloudflare speedtest

[martinbrose]

Update to closed pull request #387.

Created a new Docker image called redorbluepill/cloudflare-speedtest-exporter to replace the current Ookla Speedtest Prometheus Exporter and enabled the selection of the speedtest images through a variable called monitoring_speedtest_provider in config.yml. Replacing the image in file templates/docker-compose.yml.j2 is implemented with an if statement based on the speedtest variable in the config file. The original speedtest based on Ookla will always be the default, in case of missing config variable or misspelling.

@geerlingguy, I think that addresses your last comment on closed pull request #387.

Fixes #341:

• #341

[Maxxxel]

Does this fix the Gigabit issues with speedtest-cli?

[stale[bot]]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

[geerlingguy]

The only concern here is the maintenance of the Docker image — I'm willing to merge this in, as I do think a choice would be nice (and it may help with certain types of connections), but I also see the maintenance history of speedtest-exporter vs. cloudflare-speedtest-exporter, and just want to make sure I don't have to yank this change if the downstream image goes unmaintained and starts breaking.

[martinbrose]

Hi @geerlingguy, thanks for you reply. I'm happy to maintain the underlying repo and Docker images.

I guess for most people the Ookla speedtest should be fine. I just had the use case that it wasn't working well for me.

BR

[martinbrose]

Does this fix the Gigabit issues with speedtest-cli?

Hi @Maxxxel, I'm not sure which Gigabit issue you're talking about. Do you have an issue ID / reference?

[martinbrose]

Hi @geerlingguy,

just a gentle ping on this PR. I updated the Docker image to be significantly smaller than before by removing the Numpy dependency in the underlying Python cloudflarepycli dependency (https://github.com/tevslin/cloudflarepycli/pull/14). I think the maintenance history is also a function of the actual use of this solution. So far it's probably just me and a few other users using my Docker file.

Tbh, I don't mind either way. If you decide not to merge it, it's fine with me too... at least people can find the closed PR and take this for a spin by merging the change themselves.

[Nytelife26]

interestingly, after making the switch over, the exporter outputs 2 decimal places to the log, but either Grafana or Prometheus seems to be truncating it. i am not sure why, but the graphs and gauge readings now only display integers.

this is likely not a result of your tooling, but i was wondering if you had any ideas. in any case, it's nice to have alternatives. i am hoping this might get merged in.

[martinbrose]

Hi @Nytelife26,

thanks for your sharing your observation. I'm currently on holidays, but will have a look on my return next week.

Cheers

[martinbrose]

Hi @Nytelife26,

my apologies, left this hanging for a while but finally got around looking into it. The problem was within my code base where I used int() at one point.

This should be solved with the latest commit and the new release https://github.com/martinbrose/cloudflare-speedtest-exporter/releases/v1.2.0.

Feel free to check this out with the latest container from Docker Hub or GHCR.

[Nytelife26]

my apologies, left this hanging for a while but finally got around looking into it. The problem was within my code base where I used int() at one point.

This should be solved with the latest commit and the new release https://github.com/martinbrose/cloudflare-speedtest-exporter/releases/v1.2.0.

consider me sold, i'll be trialling your exporter full time and i'll let you know if anything else is up, but i think it should be a strong alternative. good work :)

[github-actions[bot]]

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.