ansible-role-swap icon indicating copy to clipboard operation
ansible-role-swap copied to clipboard

Would like to be able to set mount options

Open iay opened this issue 1 year ago • 3 comments

The mount line in /etc/fstab is hard-wired to have options set to "sw". It would be nice to be able to override this default, for example to set a discard policy.

Let me know if you'd be interested in a PR for this one.

iay avatar Apr 21 '24 21:04 iay

I also thought the same thing - https://github.com/geerlingguy/ansible-role-swap/pull/12. I ended up using a fork.

colin-nolan avatar May 01 '24 20:05 colin-nolan

@colin-nolan was it your fork? is this role no longer maintained?

khawarizmus avatar Jun 29 '24 07:06 khawarizmus

was it your fork?

Yes - here's what I'm currently using in my Galaxy requirements yml:

  # Forked from upstream with PRs that will never be merged:
  #   - https://github.com/geerlingguy/ansible-role-swap/pull/11
  #   - https://github.com/geerlingguy/ansible-role-swap/pull/12
  - name: geerlingguy.swap
    src: https://github.com/colin-nolan/ansible-role-swap.git
    version: 82f2466905b3d01fe9ab825534370c4730fa9590

is this role no longer maintained?

I can't comment on this role's maintainence status but I can direct you towards this (admittedly, rather old) post by Jeff: https://www.jeffgeerling.com/blog/2016/why-i-close-prs-oss-project-maintainer-notes.

I see a lot of PRs for one-off functionality that I've personally never seen in the wild. Sure there are unicorn systems out there that need to configure hairy details in some obscure app... but I'm not going to include code for that in my projects because (a) I don't use it, so I can't vouch for it, and (b) it adds maintenance overhead—even if it's a 'simple' addition. If you are one of the unicorns, please fork my work. I won't get offended!

colin-nolan avatar Jul 01 '24 14:07 colin-nolan

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Nov 01 '24 03:11 github-actions[bot]

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

github-actions[bot] avatar Jan 03 '25 03:01 github-actions[bot]