ansible-role-postgresql icon indicating copy to clipboard operation
ansible-role-postgresql copied to clipboard

Published 20 hours ago • verified publisher icon geerlingguy

Custom data dir

Open misilot opened this issue 2 years ago • 20 comments

Fixes bugs #158, #40, #124 allowing for a custom data directory

This is a rebased version of #160, and #179

misilot avatar Mar 24 '22 21:03 misilot

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Jun 23 '22 03:06 stale[bot]

Rather, unless something is breaking stability (e.g. a project I maintain won't install anymore, or breaks completely and CI blows up), or there's a major feature or missing component that I agree would be a no-brainer to have incorporated

I reckon this is a no-brainer.

lingfish avatar Jul 19 '22 00:07 lingfish

This issue is no longer marked for closure.

stale[bot] avatar Jul 19 '22 00:07 stale[bot]

@geerlingguy any chance of this being merged?

The biggest use case for this is we can put it onto a separate volume than root without having all of /var in a separate disk in AWS.

misilot avatar Aug 02 '22 22:08 misilot

Not stale

On Jun 22, 2022, at 9:00 PM, stale[bot] @.***> wrote:

 This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

misilot avatar Oct 11 '22 08:10 misilot

I've tested this and it works well just by setting this in the config/vars:

postgresql_data_dir: "/data/pgsql/{{ postgresql_version }}/data"

Much easier to move the data to another mounted volume

lantrix avatar Nov 01 '22 13:11 lantrix

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Feb 18 '23 06:02 stale[bot]

Still not stale :)

misilot avatar Feb 18 '23 13:02 misilot

This issue is no longer marked for closure.

stale[bot] avatar Feb 18 '23 13:02 stale[bot]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Jun 17 '23 23:06 stale[bot]

not stale :)

On Sat, Jun 17, 2023 at 6:57 PM stale[bot] @.***> wrote:

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post https://www.jeffgeerling.com/blog/2020/enabling-stale-issue-bot-on-my-github-repositories to see the reasons why I mark pull requests as stale.

— Reply to this email directly, view it on GitHub https://github.com/geerlingguy/ansible-role-postgresql/pull/206#issuecomment-1595894959, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBHSFCLQCFVGXVMOZWD4DXLY75JANCNFSM5RSLZCZQ . You are receiving this because you authored the thread.Message ID: @.***>

misilot avatar Jun 18 '23 01:06 misilot

This issue is no longer marked for closure.

stale[bot] avatar Jun 18 '23 01:06 stale[bot]

I ended up adding a custom data directory to the molecule tests, which is why everything else is failing in the PR.

What would be the best way to handle the __postgresql_config_path: "/var/lib/pgsql/data" that won't exist if you use a custom directory? Would it make sense to have __postgresql_config_path: be __postgresql_config_path: "{{ postgresql_data_dir }}"?

misilot avatar Jun 26 '23 13:06 misilot

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Oct 27 '23 19:10 github-actions[bot]

not stale

On Fri, Oct 27, 2023 at 2:57 PM github-actions[bot] < @.***> wrote:

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post https://www.jeffgeerling.com/blog/2020/enabling-stale-issue-bot-on-my-github-repositories to see the reasons why I mark issues as stale.

— Reply to this email directly, view it on GitHub https://github.com/geerlingguy/ansible-role-postgresql/pull/206#issuecomment-1783435545, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBHSE4JMJVNW34EYG6ZMDYBQG2PAVCNFSM5RSLZCZ2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZYGM2DGNJVGQ2Q . You are receiving this because you authored the thread.Message ID: @.***>

misilot avatar Oct 27 '23 20:10 misilot

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Mar 08 '24 19:03 github-actions[bot]

no stale

misilot avatar Mar 10 '24 13:03 misilot

So it's failing on the EL versions because __postgresql_config_path is defaulting to the old data directory I believe?

Is there a way in molecule to have specific variables for the different distros?

misilot avatar Mar 10 '24 14:03 misilot