ansible-role-php icon indicating copy to clipboard operation
ansible-role-php copied to clipboard

Allow extra settings per pool, fix #350

Open steinbrueckri opened this issue 2 years ago • 17 comments

steinbrueckri avatar Mar 30 '22 11:03 steinbrueckri

Could you please take a look at this one @geerlingguy ? It's a follow up from the discussion in #350 - thanks!

shakalandy avatar Apr 27 '22 18:04 shakalandy

Hey @geerlingguy sorry to bother you, if those changes look OK for you, could you please merge and tag a new version? Thanks!

BapRx avatar Jun 13 '22 06:06 BapRx

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Sep 19 '22 23:09 stale[bot]

Bump

steinbrueckri avatar Sep 20 '22 05:09 steinbrueckri

This issue is no longer marked for closure.

stale[bot] avatar Sep 20 '22 05:09 stale[bot]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Dec 21 '22 04:12 stale[bot]

Bump

steinbrueckri avatar Dec 21 '22 09:12 steinbrueckri

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

stale[bot] avatar Jan 21 '23 16:01 stale[bot]

Bump

steinbrueckri avatar Jan 23 '23 08:01 steinbrueckri

This pull request is no longer marked for closure.

stale[bot] avatar Apr 05 '23 17:04 stale[bot]

Re-testing

geerlingguy avatar Apr 05 '23 17:04 geerlingguy

Ok will check asap 🙇‍♂️

steinbrueckri avatar Apr 05 '23 19:04 steinbrueckri

Still getting some fails :(

geerlingguy avatar Jun 22 '23 03:06 geerlingguy

@geerlingguy Finally I was able to find the "Bug".

steinbrueckri avatar Jul 06 '23 13:07 steinbrueckri

@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?

steinbrueckri avatar Jul 10 '23 07:07 steinbrueckri

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Nov 11 '23 10:11 github-actions[bot]

@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?

?

steinbrueckri avatar Nov 11 '23 11:11 steinbrueckri

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Mar 23 '24 10:03 github-actions[bot]