ansible-role-php
ansible-role-php copied to clipboard
Allow extra settings per pool, fix #350
Could you please take a look at this one @geerlingguy ? It's a follow up from the discussion in #350 - thanks!
Hey @geerlingguy sorry to bother you, if those changes look OK for you, could you please merge and tag a new version? Thanks!
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
Bump
This issue is no longer marked for closure.
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
Bump
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.
Bump
This pull request is no longer marked for closure.
Re-testing
Ok will check asap 🙇♂️
Still getting some fails :(
@geerlingguy Finally I was able to find the "Bug".
@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark issues as stale.
@geerlingguy What is not the way to go? You merged #395 before this PR. In my option, PR #367 is more flexible then #395. But know there are merge conflicts? How should I deal with this or do you just want to close this PR?
?
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark issues as stale.