ansible-role-php icon indicating copy to clipboard operation
ansible-role-php copied to clipboard

Unable to set `pm.status_path`

Open doenietzomoeilijk opened this issue 3 years ago • 6 comments

Title says it all, really; the current template and vars don't allow you to set pm.status_path for a pool, unless I'm missing something obvious — which is far from impossible.

Is this an actual decision or just something that simply never came up and that you're willing to receive a PR for?

doenietzomoeilijk avatar Dec 10 '21 20:12 doenietzomoeilijk

I think it might be simpler (and more flexible) to add in a variable like php_fpm_extra_settings, and then you could define additional settings (any from https://www.php.net/manual/en/install.fpm.configuration.php that aren't already covered).

Then you could define in your playbook:

php_fpm_extra_settings: |
  pm.status_path = /my/path/here

To achieve that, in the existing template, we'd just need to add a line at the bottom:

{{ php_fpm_extra_settings }}

And in defaults/main.yml, a new setting like:

php_fpm_extra_settings: ''

(And a line documenting the new setting in README.)

geerlingguy avatar Mar 20 '22 19:03 geerlingguy

this would be super helpful, indeed.

But what about folks using multiple pools via php_fpm_pools? Would this extra setting be added to all of the pools? Same values make sense if only defined "per pool", or?

shakalandy avatar Mar 20 '22 20:03 shakalandy

@shakalandy - I think (at least from my experience, with smaller installations / single sites), we're starting to get into more narrow use cases, and at that point I'd rather someone forks the role and tailors it to their use case better.

geerlingguy avatar Mar 20 '22 20:03 geerlingguy

@geerlingguy @shakalandy I have opened a PR for this topic.

steinbrueckri avatar Mar 30 '22 11:03 steinbrueckri

It would also fix a couple of other issues (e.g. about clear_env ) and it would fix my issue - because I can't set own environment variables in pool.

marcin-github avatar May 11 '22 09:05 marcin-github

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] avatar Aug 12 '22 04:08 stale[bot]

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

stale[bot] avatar Sep 19 '22 23:09 stale[bot]

not stale

marcin-github avatar Sep 20 '22 19:09 marcin-github