ansible-role-php icon indicating copy to clipboard operation
ansible-role-php copied to clipboard

Published 20 hours ago • verified publisher icon geerlingguy

Issue #140: Added a memory-limit setting for the CLI

Open colans opened this issue 2 years ago • 9 comments

As per #140, we need a way to set a different memory limit on the CLI.

This should work for the Debian family, at least.

Cherry-picked from https://github.com/consensus-enterprises/ansible-role-php/commit/f59f2965a072c1ca7aef4f86cdafdb225f77e880.

colans avatar Oct 08 '21 22:10 colans

I fixed all of the Lint problems except for something in the "Unchanged files with check annotations" section, which I didn't want to touch because it has nothing to do with this issue.

colans avatar Oct 19 '21 20:10 colans

+1

if all issues have been addressed and the CI is passing we could merge?

Lusitaniae avatar Nov 30 '21 11:11 Lusitaniae

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Mar 19 '22 05:03 stale[bot]

Sounds good to me.

racke avatar Mar 19 '22 10:03 racke

This issue is no longer marked for closure.

stale[bot] avatar Mar 19 '22 10:03 stale[bot]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Jun 18 '22 21:06 stale[bot]

This is still ready for merging.

colans avatar Jun 19 '22 13:06 colans

This issue is no longer marked for closure.

stale[bot] avatar Jun 19 '22 13:06 stale[bot]

Looking over the existing Ansible tasks, the role writes the same PHP.ini for each of the php_conf_paths list.

Default includes fpm, apache2, cli.

Maybe a different approach could be to allow overriding template vars just for the specified conf file?

Not exactly sure how this could be done, but I'm going to look into it.

Or, overrides could be added to the conf.d dir as well...

Will keep you posted.

__php_conf_paths:
  - "/etc/php/{{ php_version }}/fpm"
  - "/etc/php/{{ php_version }}/apache2"
  - "/etc/php/{{ php_version }}/cli"
__php_extension_conf_paths:
  - "/etc/php/{{ php_version }}/fpm/conf.d"
  - "/etc/php/{{ php_version }}/apache2/conf.d"
  - "/etc/php/{{ php_version }}/cli/conf.d"

jonpugh avatar Jan 09 '23 17:01 jonpugh