ansible-role-nodejs icon indicating copy to clipboard operation
ansible-role-nodejs copied to clipboard

Fix setup-Debian.yml

Open lecorguille opened this issue 1 year ago • 1 comments

Fix https://github.com/geerlingguy/ansible-role-nodejs/issues/160

lecorguille avatar Jun 10 '24 19:06 lecorguille

By the way, it is one of the recommended encryption tool on the Privacy Tools website:

https://www.privacytools.io/secure-file-encryption

sbstn87 avatar Jun 26 '24 08:06 sbstn87

Please check https://github.com/wimpysworld/deb-get/blob/main/01-main/CONTRIBUTING.md#adding-software - in particular :

  • Only stable/production releases. Daily/nightly, betas or pre-release versions will not be accepted.
  • GitHub Releases and direct downloads must have a reliable means to dynamically determine the current upstream published version. Hardcoded versions will be not accepted.

The second is critical: we must be able to determine the version available to compare with any installed package. Typically we do this for github releases by using the api to get the "latest" release and extract the version tag.

It is likely that nightly automated releases will not be acceptable in any case (yes there are "exceptions" - which may at any time be tidied up of course). I'd recommend tweaking the automated workflows to make periodic intentional stable release versions labelled "latest" and label the nightlies as "nightly". Otherwise if declined there is always the option of an external deb-get repository supporting the nightly release, but being included in the core repo would of course be best all round.

I note also in the discussion linked above that there are indications that debian < 12 and derivatives may now be unsupported (the deb compression support). Ideally the more widely acceptable compression option has been adopted, but if not we would need to specify supported releases in the definition, so confirmation either way would be helpful.

I have a "working" definition (https://github.com/philclifford/deb-get/blob/extras/81-betas/packages/picocrypt-gui ) almost ready for a PR once the app version is not hard-coded to 1 and tagged in the release.

philclifford avatar Jun 26 '24 13:06 philclifford

Thanks for the info. I'll make a latest tag some time today or tomorrow that only releases manually.

As for the Debian version, I fixed it. Debian 11 and Ubuntu 22 should be supported.

HACKERALERT avatar Jun 26 '24 18:06 HACKERALERT

@HACKERALERT Thanks!

philclifford avatar Jun 26 '24 18:06 philclifford

@philclifford Stable tagged releases out now!

https://github.com/Picocrypt/Picocrypt/releases

Let me know if this is sufficient.

HACKERALERT avatar Jun 27 '24 02:06 HACKERALERT

@HACKERALERT Thanks Evan - sorry for the delayed response! That's sorted the github release aspect. The .deb still has the version hard-coded as "1" though, so the installed version will appear to be older than the release forever.

dpkg-deb --info ./Picocrypt.deb
 new Debian package, version 2.0.
 size 2359820 bytes: control archive=380 bytes.
     240 bytes,     6 lines      control              
 Package: picocrypt-gui
 Version: 1
 Architecture: amd64

deb-get show picocrypt-gui 
   [+] Including local package picocrypt-gui
  [!] Please consider contributing back new entries, an issue (or raise a PR) directly at https://github.com/wimpysworld/deb-get/pulls
Picocrypt
  Package:	picocrypt-gui
  Repository:	99-local
  Updater:	deb-get
  Installed:	1
  Published:	1.36
  Architecture:	amd64
  Download:	https://github.com/Picocrypt/Picocrypt/releases/download/1.36/Picocrypt.deb
  Website:	https://github.com/Picocrypt/Picocrypt/
  Summary:	Picocrypt is a very small, very simple, yet very secure encryption tool

If you could ensure the .deb is packaged with the "version" the same as the release tag. ( you might find this helpful. )

philclifford avatar Jul 08 '24 15:07 philclifford

Oops, missed that. I'll fix that in a few days (busy atm). Thanks for pointing it out.

HACKERALERT avatar Jul 09 '24 01:07 HACKERALERT

@philclifford had a minute today, fixed. Can you try again?

HACKERALERT avatar Jul 09 '24 03:07 HACKERALERT

@HACKERALERT That's fine, thanks. PR now awaiting review.

philclifford avatar Jul 09 '24 09:07 philclifford

Thanks!

HACKERALERT avatar Jul 10 '24 02:07 HACKERALERT