ansible-role-mysql icon indicating copy to clipboard operation
ansible-role-mysql copied to clipboard

Remove deprecated/removed InnoDB variables - innodb_large_prefix, innodb_file_format

Open eRadical opened this issue 4 years ago • 5 comments

There are a lot of deprecated variables in MySQL/InnoDB/MariaDB. Example: MDEV-23397.

Filling ticket to compile a full list of deprecated variables but used by this role. Then I'll follow up w/ a pull req.

eRadical avatar Jun 22 '21 10:06 eRadical

These are my findings:

  • expire_logs_days - is deprecated in MySQL in favor of binlog_expire_logs_seconds which defaults to 30 days, in MariaDB they're related as changes in one adjusts the other one - I think we should keep binlog_expire_logs_seconds and compute from mysql_expire_logs_days
  • symbolic-links - is deprecated in MySQL, not deprecated in MariaDB - I think we ought to remove it
  • innodb_large_prefix - deprecated in both - we ought to remove it completely
  • innodb_file_format - deprecated in both - we ought to remove it completely

Also I thin pid-file should also be deprecated as it can be absent when SystemD is used.

@geerlingguy thoughts?

eRadical avatar Jun 26 '21 13:06 eRadical

I'm okay with all those changes—the only one I think could be weird is symbolic-links. Not sure if people use it much (I don't... but I can't speak for all users of the role).

geerlingguy avatar Jun 28 '21 15:06 geerlingguy

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] avatar Sep 26 '21 23:09 stale[bot]

Still here! Not stale!

eRadical avatar Sep 30 '21 19:09 eRadical

This issue is no longer marked for closure.

stale[bot] avatar Sep 30 '21 19:09 stale[bot]