ansible-role-kubernetes
ansible-role-kubernetes copied to clipboard
changed master to control plane to be more compliant
Signed-off-by: ra-rau [email protected]
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
Not stale, though it looks like this PR needs rebase — I was checking through changelogs and couldn't find when the change was officially made to update the nomenclature.
It looks like much of K8s docs now mention "control plane" instead of master, but there are still a lot of things (like the node taint property) that still use master
as the terminology.
It's a little confusing IMO, but I would like to wait on merging something like this without also having a reference in this PR (just the comments, no need in code) to a K8s changelog message or release notes about the change (or even a relevant discussion), and also I'll need to tag a new major version because this would be a breaking change for role users.
(Edit: Closest discussion I could find is https://github.com/kubernetes/website/issues/21621 — but I can't find any authoritative changelog / guide / document for the whole thing...)
This issue is no longer marked for closure.
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
This pull request is no longer marked for closure.
See above commit—I added you as a co-author so hopefully github picks up the attribution accordingly... Further work will go into follow-ups.