ansible-role-java icon indicating copy to clipboard operation
ansible-role-java copied to clipboard

man directory task always changed on Ubuntu 20.04

Open andyshinn opened this issue 3 years ago • 0 comments

On Ubuntu 20.04 (and maybe others) the man directory task is changed when running next day (maybe automatic updates changing permissions?). Would be nice to be able to exclude this task (not sure what it is accomplishing).

andyshinn avatar May 27 '22 17:05 andyshinn

This appears to be due to #110.

It looks like the intention behind that change was to simply be explicit about the mode for /usr/share/man/man1 itself (i.e. good practice for ansible.builtin.file), but together with recurse: true, this now sets 0755 to all contained files as well.

Some digging shows that the recurse: true line originally stems from 73a17ac2d174d7caff61040ffce8737087976160 (introduced to a test, later molecule (c393b08f14fbde447612c58471df7600e42164d7), later regular task (ee7c12b13aa594dc747892860e563f45794e94d0)).

So is it possible that this was an oversight, and could recurse: true be removed at this point?

martinwe-adfinis avatar Aug 17 '22 15:08 martinwe-adfinis

Can you file a PR with that change and we'll see if it passes the idempotence test?

geerlingguy avatar Aug 17 '22 15:08 geerlingguy

Thanks for the fast response! I've opened #131.

martinwe-adfinis avatar Aug 17 '22 17:08 martinwe-adfinis

Looks like it worked. Merged! This is in the latest tag, too :)

geerlingguy avatar Aug 17 '22 20:08 geerlingguy

Nice, thanks! :-D

martinwe-adfinis avatar Aug 18 '22 10:08 martinwe-adfinis