ansible-role-filebeat icon indicating copy to clipboard operation
ansible-role-filebeat copied to clipboard

Configuration of filebeat modules

Open DominiqueFuchs opened this issue 1 year ago • 3 comments

Hi there,

As I'm using filebeat modules, I'm currently using a custom template for the ansible role. After looking through your repo to see if any configuration options (or jinja template snippets) exist, I noticed they don't and I'm not the first one (fixes #26 - and after creating the PR I also discovered #46 and #48).

This PR does

  1. Add a template snippets for the module configuration (the default one that ships with filebeat installation)
  2. Makes the snippet dependant on three new variables for the role configuration
  3. Adds the aforementioned variables, again with filebeats default values
  4. Makes note of the options within README.md

I did a (admittedly really quick) search if false would be a better default because of version differences, but AFAICT these corresponding functionality and path values existed like forever so I went with true, which resembles the state after a manual filebeat installation anyway.

Greetings 👋🏻

DominiqueFuchs avatar May 06 '23 11:05 DominiqueFuchs

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Sep 03 '23 19:09 github-actions[bot]

This would be nice to have

JoyceBabu avatar Sep 27 '23 15:09 JoyceBabu

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] avatar Feb 04 '24 19:02 github-actions[bot]

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

github-actions[bot] avatar Apr 07 '24 19:04 github-actions[bot]