ansible-role-docker icon indicating copy to clipboard operation
ansible-role-docker copied to clipboard

Add OS specific variable overrides.

Open adamus1red opened this issue 2 years ago • 5 comments

Specific example is Alpine where the repos use docker rather than docker-ce or docker-ee

adamus1red avatar Dec 31 '21 15:12 adamus1red

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Apr 16 '22 00:04 stale[bot]

In case this approach gets approved, it could also include an Archlinux.yml file with docker_package: "docker" too.

adamantike avatar Apr 23 '22 23:04 adamantike

This issue is no longer marked for closure.

stale[bot] avatar Apr 23 '22 23:04 stale[bot]

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] avatar Jul 30 '22 21:07 stale[bot]

I would really appreciate if this can be reviewed, considering that is the only missing change for this role to work out of the box with Arch Linux based distros (otherwise, docker_package has to be set to "docker").

adamantike avatar Jul 30 '22 22:07 adamantike

I've merged this in to make it more convenient for Arch/Alpine users, but note that precedence means it could be harder for end users to override any vars defined in these included files. So use them sparingly—it makes the role a tiny bit less flexible while also making some platforms better supported OOTB.

@adamantike - if you want to add in a separate PR to add Arch support I'd be willing to merge it (make sure to add to meta/main.yml the new platform, and make sure the name of the file is correct with correct capitalization (not sure if ArchLinux, Arch, or Archlinux)).

geerlingguy avatar Aug 19 '22 19:08 geerlingguy