ansible-role-certbot
ansible-role-certbot copied to clipboard
Implement support for DNS install method
This PR implements support for the DNS install method (#186). Any provider specific configuration is considered out of scope; I updated the docs to describe how to achieve this using standard Ansible functionality. As a result, there are minimal changes required.
Hey, Thanks for this PR, I'm currently testing it :)
I was checking the README, and I don't think the certbot_create_extra_args var is actually used in the certbot_create_command var.
Hey, Thanks for this PR, I'm currently testing it :)
I was checking the README, and I don't think the
certbot_create_extra_argsvar is actually used in thecertbot_create_commandvar.
Nevermind, it's just me being blind :-)
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark issues as stale.
Hi! PR author here. Thanks for the link to the blog post, I can surely empathise with your reluctance to provide unpaid code review. However I was wondering if you'd reconsider your decision on this occasion given that:
- Without the DNS method, wildcard cert generation is quite difficult
- Interest in this feature has been expressed in previous issues and PRs
- You've expressed an interest in this feature, if it was implemented in a simple way (to paraphrase)
- The implementation in this PR is pretty minimal, most of the changes are to documentation
FWIW, I've been using this code to generate and wildcard certs in production for the past few months and I've not encountered any issues. Thanks for your consideration, and for a great Ansible role.