ansible-role-certbot
ansible-role-certbot copied to clipboard
geerlingguy
introduce certbot_create_extra_args (for custom RSA key size)
This should fix #100.
It was tested on a real server and I always use it now (on top of #97 PR in my webroot-enhanced branch).
Thanks, updated. I was not able to test it as I do not have any new certificate to generate right now, but I trust you that this will work as fine. No parse error at least.
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
From https://www.jeffgeerling.com/blog/2020/enabling-stale-issue-bot-on-my-github-repositories:
[…] Many issues are opened and never get a follow-up visit from the original author (even if I spend a half hour providing a thorough response). Often this person found a solution elsewhere and never thought to follow-up, or they don't have notifications enabled so they never even know someone responded.
Dear stale bot, we are in the opposite case here: the PR has not been reviewed by the maintainer yet. This PR still applies. Yes, I am negotiating with a bot. :)
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
I wonder... since there are other CLI options too, which people may want control over... maybe we should just have a var like certbot_create_extra_args and you can throw whatever you want in there?
Hello geerlingguy, nice to hear from you.
I wonder... since there are other CLI options too, which people may want control over... maybe we should just have a var like certbot_create_extra_args and you can throw whatever you want in there?
Pros : more flexible, allows to specify a lot of things. Cons: less discoverable for people not familiar with certbot options.
How about I update this PR to introduce both?
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
I think this is still relevant. @MicroJoe did you have time to include the suggested certbot_create_extra_args as suggested by @geerlingguy ?
Commit changed to only introduce certbot_create_extra_args so that --rsa-key-size (and other options) can be passed by end users of the role.
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.
@geerlingguy it's very unfortunate this PR was closed, especially since all your comments have been taken into account already by @MicroJoe and the functionality would present a very useful addition to the role.
